Clarify what fields in models are required.

[mohsen1]

No description provided.

[drolando]

@adriancole bump. zipkin2-api.yaml says which fields you can leave absent. zipkin-api.yaml doesn't say anything about it.

Since they're not listed as required, I'd assume everything is optional and I can just avoid it. Whereas you comments on Yelp/py_zipkin#102 seem to suggest even in JSON I'd need to default port to 0 and serviceName to ""

[codefromthecrypt]

technically you are right.. we (I) didn't spend any time going back to discuss v1 in the spec, hoping people stop using it :)

anyway I will put some notes down

[codefromthecrypt]

ps you don't need to default port to 0.. unless I had a brain cramp I thought I said please don't default it to zero :D

…

On Tue, Oct 9, 2018 at 2:21 AM Daniele ***@***.***> wrote: @adriancole <https://github.com/adriancole> bump. zipkin2-api.yaml says which fields you can leave absent. zipkin-api.yaml doesn't say anything about it. Since they're not listed as required, I'd assume everything is optional and I can just avoid it. Whereas you comments on Yelp/py_zipkin#102 <Yelp/py_zipkin#102> seem to suggest even in JSON I'd need to default port to 0 and serviceName to "" — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD610dQZTZFiGnyp-5VPv2m6frSlZaPks5ui5emgaJpZM4HB64u> .

[codefromthecrypt]

#54 for v1

I'll just make the change directly to v2 as only 2 fields are required though it would be silly to only serialize traceId, spanId

[codefromthecrypt]

oops v2 format already says so..

    required:
      - traceId
      - id