Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zimcheck does not complains on externals background-image: url("...") #297

Open
benoit74 opened this issue Apr 21, 2022 · 3 comments
Open

Zimcheck does not complains on externals background-image: url("...") #297

benoit74 opened this issue Apr 21, 2022 · 3 comments
Labels
enhancement zimcheck

Comments

@benoit74
Copy link
Contributor

When a page has an element with an inline style with a background-image referring to an external URL, zimcheck should raise an error.

Exemple:

<div style="background-image:url(&quot;https://i.ytimg.com/vi/ppSnb4A2WWw/hqdefault.jpg&quot;)" width="560" height="315"></div>
@rgaudin
Copy link
Member

rgaudin commented Apr 22, 2022

Yes, zimcheck relies on regexp and has many limitations. We already have several tickets but I believe the potential solution is laid out in #149

@kelson42
Copy link
Contributor

kelson42 commented Apr 22, 2022 •
edited
Loading

@rgaudin Definitly! One small problem, it seems that libgumbo is not maintained anymore :(

@kelson42
Copy link
Contributor

Blocked by #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement zimcheck
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rgaudin @kelson42 @benoit74