Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dev or nightly docker image #252

Open
rgaudin opened this issue Jul 11, 2021 · 4 comments
Open

Add a dev or nightly docker image #252

rgaudin opened this issue Jul 11, 2021 · 4 comments

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 11, 2021

Currently, we only offer docker images for released version. Having up-to-date docker images is generally helpful and nice but in our situation of not releasing for 6months+, it's become much needed ; particularly since we have other tools integrating zimcheck (zimfarm, scraper CI).

In #249, I proposed to create a nightly docker image tag that would be built exactly as the release one, but instead of downloading a release tarball, it would donwload the latest nightly one. This is a close-to-zero effort solution that would offer a 24h-old docker image to all.

@kelson42 is in favor of a standard dev image that would be built from the master source. While I agree it has additional advantages (zero delay, tests building as well), it requires more effort: we need to create that Dockerfile from scratch and maintain it over time while kiwix-build already constructs and publish builds for the nightlies.

@kelson42
Copy link
Contributor

Difficult ticket, an other approach would be to just acknowledge our failure of releasing zim-tools in a reasonable delay, wait this is done and suffer... and do our best that this don't occurr any time soon again?

@rgaudin
Copy link
Member Author

rgaudin commented Jul 11, 2021

I don't get how this would be better than the nightly way. There must be a downside of publishing this that I don't see. Obviously, as soon as we have a release, our integrations would use the released version.

@kelson42
Copy link
Contributor

kelson42 commented Jul 11, 2021

The only downside I see is that this would be a premiere with Docker and that I think this is confusing with the dev tag we already use everywhere... But it is quite clear to me as well that I'm overvaluated this problem/argument.

@mgautierfr
Copy link
Collaborator

Another solution would be to not wait form python-libzim and release libzim the sooner possible :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants