Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1876 update mw action api to version 2 #1877

Merged
merged 8 commits into from
Sep 11, 2023

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

@VadimKovalenkoSNF VadimKovalenkoSNF commented Aug 2, 2023

Fixes #1876

Migrate to MW Action API v2

@VadimKovalenkoSNF VadimKovalenkoSNF linked an issue Aug 2, 2023 that may be closed by this pull request
@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the 1876-update-mw-action-api-to-version-2 branch from 3a44355 to 7a4f8a2 Compare September 7, 2023 14:58
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (2c5553b) 71.68% compared to head (2b736c5) 71.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1877   +/-   ##
=======================================
  Coverage   71.68%   71.68%           
=======================================
  Files          33       33           
  Lines        2801     2801           
  Branches      625      626    +1     
=======================================
  Hits         2008     2008           
  Misses        680      680           
  Partials      113      113           
Files Changed Coverage Δ
src/MediaWiki.ts 85.86% <75.00%> (ø)
src/Downloader.ts 59.16% <100.00%> (ø)
src/util/builders/url/api.director.ts 89.47% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@VadimKovalenkoSNF VadimKovalenkoSNF marked this pull request as ready for review September 8, 2023 07:46
@kelson42 kelson42 force-pushed the 1876-update-mw-action-api-to-version-2 branch from 7cdfc92 to 2b736c5 Compare September 8, 2023 12:11
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42
Copy link
Collaborator

kelson42 commented Sep 8, 2023

@VadimKovalenkoSNF When this version2 has been introduced? We have a minimal Mediawiki version supported, and would like to know if we have to change it.

@kelson42 kelson42 merged commit 148b133 into main Sep 11, 2023
5 of 6 checks passed
@kelson42 kelson42 deleted the 1876-update-mw-action-api-to-version-2 branch September 11, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MW Action API to version 2
2 participants