Skip to content

Commit

Permalink
Update the Windows Docker CI image to include the C++ ATL library.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 705651893
  • Loading branch information
belitskiy authored and Google-ML-Automation committed Dec 12, 2024
1 parent ebc8a58 commit cb6562b
Show file tree
Hide file tree
Showing 12 changed files with 86 additions and 106 deletions.
86 changes: 37 additions & 49 deletions third_party/tsl/tools/toolchains/win/20240424/BUILD

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ that clang-cl reported. This file is a dependency of every compilation action an
changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.


Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.


Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
REPOSITORY TAG DIGEST IMAGE ID CREATED SIZE
gcr.io/tensorflow-testing/tf-win2019-docker-staging latest sha256:1082ef4299a72e44a84388f192ecefc81ec9091c146f507bc36070c089c0edcc b601adb43430 8 minutes ago 20.4GB
gcr.io/tensorflow-testing/tf-win2019-rbe latest sha256:d3577d20dea75966faf7fd03479c71462441937df5694259109c2ee1d002a3dd b601adb43430 8 minutes ago 20.4GB
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ def _impl(ctx):

compiler_param_file_feature = feature(
name = "compiler_param_file",
enabled = True,
)

copy_dynamic_libraries_to_binary_feature = feature(
Expand Down
4 changes: 2 additions & 2 deletions third_party/tsl/tools/toolchains/win/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ platform(
remote_execution_properties = """
properties:{
name: "container-image"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:1082ef4299a72e44a84388f192ecefc81ec9091c146f507bc36070c089c0edcc"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:d3577d20dea75966faf7fd03479c71462441937df5694259109c2ee1d002a3dd"
}
properties:{
name: "OSFamily"
Expand All @@ -43,7 +43,7 @@ platform(
remote_execution_properties = """
properties:{
name: "container-image"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:1082ef4299a72e44a84388f192ecefc81ec9091c146f507bc36070c089c0edcc"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:d3577d20dea75966faf7fd03479c71462441937df5694259109c2ee1d002a3dd"
}
properties:{
name: "OSFamily"
Expand Down
86 changes: 37 additions & 49 deletions tools/toolchains/win/20240424/BUILD

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ that clang-cl reported. This file is a dependency of every compilation action an
changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.


Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ changes to it will be reflected in the action cache key. When some of these
paths change, Bazel will make sure to rerun the action, even though none of
declared action inputs or the action commandline changes.


2 changes: 1 addition & 1 deletion tools/toolchains/win/20240424/toolchain_image_info
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
REPOSITORY TAG DIGEST IMAGE ID CREATED SIZE
gcr.io/tensorflow-testing/tf-win2019-docker-staging latest sha256:1082ef4299a72e44a84388f192ecefc81ec9091c146f507bc36070c089c0edcc b601adb43430 8 minutes ago 20.4GB
gcr.io/tensorflow-testing/tf-win2019-rbe latest sha256:d3577d20dea75966faf7fd03479c71462441937df5694259109c2ee1d002a3dd b601adb43430 8 minutes ago 20.4GB
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ def _impl(ctx):

compiler_param_file_feature = feature(
name = "compiler_param_file",
enabled = True,
)

copy_dynamic_libraries_to_binary_feature = feature(
Expand Down
4 changes: 2 additions & 2 deletions tools/toolchains/win/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ platform(
remote_execution_properties = """
properties:{
name: "container-image"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:1082ef4299a72e44a84388f192ecefc81ec9091c146f507bc36070c089c0edcc"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:d3577d20dea75966faf7fd03479c71462441937df5694259109c2ee1d002a3dd"
}
properties:{
name: "OSFamily"
Expand All @@ -43,7 +43,7 @@ platform(
remote_execution_properties = """
properties:{
name: "container-image"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:1082ef4299a72e44a84388f192ecefc81ec9091c146f507bc36070c089c0edcc"
value: "docker://gcr.io/tensorflow-testing/tf-win2019-rbe@sha256:d3577d20dea75966faf7fd03479c71462441937df5694259109c2ee1d002a3dd"
}
properties:{
name: "OSFamily"
Expand Down

0 comments on commit cb6562b

Please sign in to comment.