From ceccd884d87517b8a6238c399021d56953c99848 Mon Sep 17 00:00:00 2001
From: Antti Ylitepsa <89379237+AYlitepsa@users.noreply.github.com>
Date: Tue, 5 Sep 2023 22:21:46 +0300
Subject: [PATCH] Deleted setting default value {} for config in init. Ensured
 that no field in config was changed inside the funtions. Added test script
 example in the documentation. (#10413)

---
 modules/neuwoRtdProvider.js | 18 +++++++++---------
 modules/neuwoRtdProvider.md |  2 ++
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/modules/neuwoRtdProvider.js b/modules/neuwoRtdProvider.js
index 00a3c59b4a6..881bbc10b11 100644
--- a/modules/neuwoRtdProvider.js
+++ b/modules/neuwoRtdProvider.js
@@ -10,14 +10,14 @@ const SEGTAX_IAB = 6 // IAB - Content Taxonomy version 2
 const RESPONSE_IAB_TIER_1 = 'marketing_categories.iab_tier_1'
 const RESPONSE_IAB_TIER_2 = 'marketing_categories.iab_tier_2'
 
-function init(config = {}, userConsent) {
-  config.params = config.params || {}
+function init(config, userConsent) {
+  // config.params = config.params || {}
   // ignore module if publicToken is missing (module setup failure)
-  if (!config.params.publicToken) {
+  if (!config || !config.params || !config.params.publicToken) {
     logError('publicToken missing', 'NeuwoRTDModule', 'config.params.publicToken')
     return false;
   }
-  if (!config.params.apiUrl) {
+  if (!config || !config.params || !config.params.apiUrl) {
     logError('apiUrl missing', 'NeuwoRTDModule', 'config.params.apiUrl')
     return false;
   }
@@ -25,14 +25,14 @@ function init(config = {}, userConsent) {
 }
 
 export function getBidRequestData(reqBidsConfigObj, callback, config, userConsent) {
-  config.params = config.params || {};
+  const confParams = config.params || {};
   logInfo('NeuwoRTDModule', 'starting getBidRequestData')
 
-  const wrappedArgUrl = encodeURIComponent(config.params.argUrl || getRefererInfo().page);
+  const wrappedArgUrl = encodeURIComponent(confParams.argUrl || getRefererInfo().page);
   /* adjust for pages api.url?prefix=test (to add params with '&') as well as api.url (to add params with '?') */
-  const joiner = config.params.apiUrl.indexOf('?') < 0 ? '?' : '&'
-  const url = config.params.apiUrl + joiner + [
-    'token=' + config.params.publicToken,
+  const joiner = confParams.apiUrl.indexOf('?') < 0 ? '?' : '&'
+  const url = confParams.apiUrl + joiner + [
+    'token=' + confParams.publicToken,
     'url=' + wrappedArgUrl
   ].join('&')
   const billingId = generateUUID();
diff --git a/modules/neuwoRtdProvider.md b/modules/neuwoRtdProvider.md
index 2adead66d4e..fb52734d451 100644
--- a/modules/neuwoRtdProvider.md
+++ b/modules/neuwoRtdProvider.md
@@ -33,6 +33,8 @@ pbjs.setConfig({realTimeData: { dataProviders: [ neuwoDataProvider ]}})
 
 # Testing
 
+`gulp test --modules=rtdModule,neuwoRtdProvider`
+
 ## Add development tools if necessary
 
 - Install node for npm