You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When operating under load, the following RuntimeWarning gets generated in our logs:
RuntimeWarning: coroutine 'IndyVdrLedgerPool.context_close.<locals>.closer' was never awaited
As far as I can tell, this likely occurs when IndyVdrLedgerPool's async close task gets garbage collected. Or, perhaps the background task gets created too many times when acapy is under load, and doesn't always get scheduled properly. It's not yet clear why it occurs. And it doesn't appear to cause any other issues, but it's worth investigating, as the code might be behaving in unexpected ways.
The issue can also manifest as:
Exception ignored in: <coroutine object IndyVdrLedgerPool.context_close.<locals>.closer at 0x7ff607befe20>
Traceback (most recent call last):
File "<string>", line 1, in<lambda>
KeyError: '__import__'
I can't really tell what's going on here, but wanted to record it so long as we're debugging a fix.
Edit:
The exception associated with the runtime warning appears to be a red herring - it just depends on what task was running concurrently. This RuntimeWarning seems to only appear on DataDog. So, as far as I can tell, the coroutine .. was never awaited issue would usually occur silently, but due to DataDog / ddtrace injection, it picks up on it.
I have a fix for this, but I'll try include some before/after testing to validate that the fix is really necessary.
The text was updated successfully, but these errors were encountered:
When operating under load, the following RuntimeWarning gets generated in our logs:
RuntimeWarning: coroutine 'IndyVdrLedgerPool.context_close.<locals>.closer' was never awaited
As far as I can tell, this likely occurs when
IndyVdrLedgerPool
's async close task gets garbage collected. Or, perhaps the background task gets created too many times when acapy is under load, and doesn't always get scheduled properly. It's not yet clear why it occurs. And it doesn't appear to cause any other issues, but it's worth investigating, as the code might be behaving in unexpected ways.The issue can also manifest as:
I can't really tell what's going on here, but wanted to record it so long as we're debugging a fix.
Edit:
The exception associated with the runtime warning appears to be a red herring - it just depends on what task was running concurrently. This RuntimeWarning seems to only appear on DataDog. So, as far as I can tell, the
coroutine .. was never awaited
issue would usually occur silently, but due to DataDog / ddtrace injection, it picks up on it.I have a fix for this, but I'll try include some before/after testing to validate that the fix is really necessary.
The text was updated successfully, but these errors were encountered: