Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Issued To" Not Displaying When Using Identifier in CredentialSubject #632

Closed
kayaelle opened this issue Aug 6, 2024 · 5 comments
Closed
Assignees
Labels
bug Schedule this bug Build82 priority

Comments

@kayaelle
Copy link
Contributor

kayaelle commented Aug 6, 2024

Describe the bug
In relation to closed issue:
https://github.com/digitalcredentials/learner-credential-wallet/issues/539

This credential template: https://dashboard.dcconsortium.org/admin/collections/credential-template/66a3b2db6789dd1f426dab93 should produce a credential than uses the code implemented for issue #539 but "Issued To" is not displaying in the LCW.

It is displaying fine in the signed example that @alexfigtree mentions in #539 but this is because the credential also contains credentialSubject.name - the old way that we have included Issued to.

To Reproduce
Steps to reproduce the behavior:

  1. Use the demo issuer to issue a credential to the LCW using this template: https://dashboard.dcconsortium.org/admin/collections/credential-template/66a3b2db6789dd1f426dab93
  2. View Credential

Alternative way to reproduce:
re-sign example that @alexfigtree mentions in #539 without credentialSubject.name in the data.

Expected behavior
Issued To should be displayed in the credential display if there is an identifier in the credential subject that looks like:

"identifier":[ { "type":"IdentityObject", "hashed":false, "identityHash":"Sam Smith", "identityType":"name"} ],

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@kayaelle kayaelle changed the title Issued to Not Displaying When Using Identifier in CredentialSubject "Issued To" Not Displaying When Using Identifier in CredentialSubject Aug 6, 2024
@kayaelle kayaelle assigned kayaelle and alexfigtree and unassigned kayaelle Aug 6, 2024
@kayaelle kayaelle moved this to To Do (Current sprint) in DCC Engineering Aug 6, 2024
@kayaelle kayaelle moved this from To Do (Current sprint) to LCW Backlog in DCC Engineering Aug 6, 2024
@alexfigtree alexfigtree moved this from LCW Backlog to In Progress in DCC Engineering Aug 15, 2024
@alexfigtree
Copy link
Contributor

Related to #539

@alexfigtree alexfigtree added bug Schedule this bug priority labels Aug 16, 2024
@alexfigtree
Copy link
Contributor

Need to re-release on iOS Test Flight to verify issue; waiting from MIT re: profile/cert issue in order to Distribute app

@alexfigtree
Copy link
Contributor

alexfigtree commented Sep 19, 2024

Display rules for Open Badges:

  1. When both credentialSubject.name and identityHash (New display rule for open badges New display rule for open badges #641)
  • Open Badges: prioritize identityObject ignore credentialSubject.name //ideally
  1. When identityHash only (do not show up for VC's)
  • identityHash shows
  1. When both are missing:
  • Do not show "Issued To"

@alexfigtree alexfigtree moved this from In Progress to Ready for PR Review/re-test in DCC Engineering Sep 19, 2024
@alexfigtree
Copy link
Contributor

Currently passing Rules 2 and 3 above, opened new ticket for 1 (New display rule for open badges #641) on Build 82, moving to Release Ready

@alexfigtree alexfigtree moved this from Ready for PR Review/re-test to Release Ready in DCC Engineering Sep 25, 2024
@alexfigtree alexfigtree moved this from Release Ready to Done (Deployed) in DCC Engineering Oct 10, 2024
@alexfigtree
Copy link
Contributor

Completed, moving to Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Schedule this bug Build82 priority
Projects
None yet
Development

No branches or pull requests

2 participants