Add parametrization for the detokenization/decoding #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: LLM
pavel-esir
force-pushed
the
parametrize_decode
branch
from
f3b7732 to
e46466d
Compare
pavel-esir
commented
Nov 22, 2024
| @@ -217,3 +217,25 @@ def test_add_special_tokens(add_special_tokens, prompt): | |||
| res_genai = genai_tokenzier.encode(prompt, add_special_tokens).input_ids.data | |||
| res_hf = hf_tokenizer(prompt, return_tensors="np", add_special_tokens=add_special_tokens)["input_ids"] | |||
| assert np.all(res_genai == res_hf) | |||
|
|
|||
| @pytest.mark.precommit | |||
| @pytest.mark.xfail(reason="Need to turn them back on when openvino_tokenizers will be updated.") | |||
There was a problem hiding this comment.
This tests will be green on CI only after genai will be update to the latest openvino_tokenizers. Meantime checked them locally, will enable back as soon as openvino_tokenziers will be updated.
apaniukov
approved these changes
Nov 26, 2024
ilya-lavrenov
approved these changes
Nov 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Need to enable feature in 2024.6 release as well (port 2024.5 branch). |
Merged
ilya-lavrenov
added a commit
that referenced
this pull request
Dec 4, 2024
- #1158 - #1178 - #1214 - #1243 - #1253 - #1259 - #1266 - #1271 - #1278 - #1280 - #1284 - e4a86f6 - #1246 - #958 --------- Co-authored-by: Anastasiia Pnevskaia <[email protected]> Co-authored-by: Helena Kloosterman <[email protected]> Co-authored-by: Vladimir Zlobin <[email protected]> Co-authored-by: Dmitry Matveev <[email protected]> Co-authored-by: Anna Likholat <[email protected]> Co-authored-by: Alina Kladieva <[email protected]>
|
Discussed with @andrei-kochin, since OVMS will not use this feature in 2024.6, no need to port it there. Ilya already removed label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged
Ticket CVS-154151