About get_random_items method in Visualizer

[irmo322]

Hi,

Visualizer class has a method named get_random_items(n_samples) in which dataset items are chosen using random.choices.
I expect get_random_items to not choose the same item multiple times, which can occur with random.choices.

Replacing random.choices by random.sample would solved this issue.

Also, I wonder why get_random_items is not in Dataset class in the first place. This functionality is not really related to visualization and is useful is other cases.

Thanks for reading.

[vinnamkim]

Hi @irmo322, Thanks for your interests on our project. I'll put your suggestion in our backlog. Or, you can open a PR if you want. We greatly appreciate the participation from the open community.

[ChaitanyaYeole02]

Hey @vinnamkim, I am interested to work on this issue. Can you please assign it to me?

[vinnamkim]

Hey @vinnamkim, I am interested to work on this issue. Can you please assign it to me?

Sure, it's always welcome.