Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalendarServiceDataFactoryImpl high memory usage #2163

Closed
marcioaguiar opened this issue Nov 5, 2015 · 2 comments
Closed

CalendarServiceDataFactoryImpl high memory usage #2163

marcioaguiar opened this issue Nov 5, 2015 · 2 comments
Labels
Stale This issue is stale, no activity for 90 days. Remove stale label or comment within 30 days.

Comments

@marcioaguiar
Copy link

I know this is a onebusaway gtfs module problem as stated by me here: OneBusAway/onebusaway-gtfs-modules#59

I thought the OBA lib was going to be deprecated on OTP since I saw this issue:
#1508

But I checked the new 0.19 release and it still takes forever and demands VERY HIGH memory usage in my use case. The real problem is with CalendarServiceDataFactoryImpl which create every single date object for every ServiceCalendar period.

It's being used on GtfsModule.buildGraph

Are you planning to remove OBA completely? Is a pull request welcome or are you already on it?

I can upload my gtfs if needed.

Thanks.

@abyrd
Copy link
Member

abyrd commented Nov 5, 2015

Our new GTFS library should indeed have less memory-intensive behavior as described in #1508. However, we were connecting that library to our new routing implementation which has recently been moved out into a separate repository (https://github.com/conveyal/r5). We (Conveyal) haven't yet successfully connected gtfs-lib to OpenTripPlanner and probably won't do so anytime soon, since we've decided to put most of our effort into the new repo.

But all the components are open source. You're certainly welcome to adapt OTP to use those libraries and contribute the changes. Alternatively, OTP is now depending on a fork of the OBA GTFS loader so you could also just modify that project to have more efficient behavior.

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale This issue is stale, no activity for 90 days. Remove stale label or comment within 30 days. label Jun 5, 2022
@github-actions github-actions bot closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale This issue is stale, no activity for 90 days. Remove stale label or comment within 30 days.
Projects
None yet
Development

No branches or pull requests

2 participants