Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Finish time of child Span (ChildOf reference) #139

Open
lookfwd opened this issue May 23, 2019 · 4 comments
Open

Finish time of child Span (ChildOf reference) #139

lookfwd opened this issue May 23, 2019 · 4 comments

Comments

@lookfwd
Copy link

lookfwd commented May 23, 2019

image

Wondering about Child D from here. it's a bit weird, isn't it?

@lookfwd lookfwd changed the title Finish time of child-of relationship Finish time of child Span (ChildOf reference) May 23, 2019
@eyjohn
Copy link

eyjohn commented May 29, 2019

To me, it comes down to whether the data model sets a constraint on:

A child span can not outlive its parent

I do not see any references to this in the specification, and I would suggest that if this is not a requirement that it actually be explicitly stated that this is not guaranteed, rather than some-one inferring it from the diagram.


As a side-point, I do see the appeal of adding such a constraint on the data-model as it does capture the nature of request/response based systems well, i.e. you can guarantee that all child requests have returned by the time the response gets sent back (timeouts + gradual degradation being the exception perhaps).

However in-practice, enforcing such a constraint in the framework is a bit tricky, especially given that say clock skew between two processes can invalidate this when looking at timestamps. Likewise it imposes a potentially difficult implementation of the tracing model. As such I would suggest this be seen more as a Best Practice rather than data model constraint.

@yurishkuro
Copy link
Member

There is no requirement that child finishes before parent. The most common use case for this is when parent is the client span and child is the server span. The client may have a timeout that would cause the parent client span to be closed before server completes processing of the request.

In other words, childOf reference implies parent's dependency on the outcome (and one of the outcomes is "server did not finish in time"), but not the causal relationship child.end happens-before parent.end

@eyjohn
Copy link

eyjohn commented Jun 3, 2019

The client may have a timeout that would cause the parent client span to be closed before server completes processing of the request.

This as interesting example and I think it would be great to explicitly include the characteristic and example in the reference.

@jmilkiewicz
Copy link

Wouldn't be the same for Child Span A and Child Span B where the former is considered a parent?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants