Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

MockTracer._allocSpan is private and can't be overwritten #126

Open
oranoran opened this issue May 29, 2019 · 2 comments · May be fixed by #127
Open

MockTracer._allocSpan is private and can't be overwritten #126

oranoran opened this issue May 29, 2019 · 2 comments · May be fixed by #127

Comments

@oranoran
Copy link

MockTracer._allocSpan is private and can't be overwritten - so trace can't be fully customized. Should be protected.

oranoran pushed a commit to oranoran/opentracing-javascript that referenced this issue May 29, 2019
@yurishkuro
Copy link
Member

Not that I am particularly opposed to this change, but making the method protected extends the API surface. Please elaborate on what you are doing with mock tracer that requires you to extend it.

@ithildir-paypal
Copy link

It appears https://github.com/opentracing/opentracing-javascript/blob/master/src/mock_tracer/mock_tracer.ts#L20-L22 explicitly talks about overriding _allocSpan, but, since it's private, this is not possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants