Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua repository #8

Open
james-callahan opened this issue Apr 27, 2018 · 3 comments
Open

Lua repository #8

james-callahan opened this issue Apr 27, 2018 · 3 comments

Comments

@james-callahan
Copy link

I'm working on a lua opentracing library.

How do I go about getting a new opentracing/opentracing-lua repository created?

@tedsuo
Copy link
Member

tedsuo commented May 8, 2018

Hi @james-callahan, sorry for the slow reply. We’re definitely interested in a Lua API!

We usually prefer to have more than one maintainer develop the API, and to test drive it in more than one project. I am happy to start with the work you are doing in Kong; it looks really good. We may try to get HAproxy or another similar project involved, but I see there is already interest from multiple developers so I am fine starting with just Kong as the initial target.

@tedsuo
Copy link
Member

tedsuo commented May 8, 2018

I've created a repo here, and added several maintainers. Feel free to port your current codebase over, without making a PR. From that point, we can review and make adjustments to bring it in line semantically with the other APIs, and then look at addressing any additional lua-specific API requirements.

For questions and discussions, consider joining the Cross-Language Working Group on gitter, found here: https://gitter.im/opentracing/cross-language

We also have a weekly working group call, currently at 8:30am Pacific every Friday. I recognize that you may be in Australia, so that call time may not work for you. In general, the OpenTracing calendar can be found here.

Welcome to the team, James! Let me know when you've had a chance to look at this, and I'll close the issue.

Cheers,
Ted

@james-callahan
Copy link
Author

I am fine starting with just Kong as the initial target.

I've been very careful to not make any kong-specific assumptions in the opentracing-lua code base.
It should be usable in any lua context.

I've created a repo here, and added several maintainers. Feel free to port your current codebase over, without making a PR.

Given that kong/opentracing-lua now exists; could you fork that to the opentracing organisation; and then we can ask github to re-parent the fork tree?

For questions and discussions, consider joining the Cross-Language Working Group on gitter, found here: https://gitter.im/opentracing/cross-language

Done :)

We also have a weekly working group call, currently at 8:30am Pacific every Friday. I recognize that you may be in Australia,

Yeah :( I won't be able to make any 8:30am US/Pacific meetings; that's 1:30am for me (on a Saturday!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants