-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of dependencies to vendor specific tracer implementations #5
Comments
Thinking a bit further, we will probably want to balance the opentracing-contrib/java-api-extensions dependency against the fact that we have very little code for the actual wrappers, and we'd have another dependency to manage. Not to mention be limited to whatever the API expose, and have less room for optimizations. The limiting factor here is what the span exposes. Operation name we can propagate ourselves. Will add another issue for that. |
See discussion at opentracing/opentracing-java#314. As soon as it is resolved, and we have all we need, all vendor specific tracer-stuff can be removed (ContextExtractor and friends). |
The opentracing-0.32.0 branch currently shows what it would look like. Sadly, we'd lose parentId as the proposal currently stands. |
The thing we would lose is reconstructing the DAG directly from recording data. It would be sexy to have it (and render it), but we could, perhaps, survive. |
Look into java-api-extensions. We will likely need opentracing-contrib/java-api-extensions#18 fixed for the thread local scope events.
The text was updated successfully, but these errors were encountered: