Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of dependencies to vendor specific tracer implementations #5

Closed
thegreystone opened this issue Nov 30, 2018 · 5 comments
Closed
Assignees

Comments

@thegreystone
Copy link
Collaborator

Look into java-api-extensions. We will likely need opentracing-contrib/java-api-extensions#18 fixed for the thread local scope events.

@thegreystone
Copy link
Collaborator Author

thegreystone commented Dec 1, 2018

Thinking a bit further, we will probably want to balance the opentracing-contrib/java-api-extensions dependency against the fact that we have very little code for the actual wrappers, and we'd have another dependency to manage. Not to mention be limited to whatever the API expose, and have less room for optimizations.

The limiting factor here is what the span exposes. Operation name we can propagate ourselves. Will add another issue for that.

@thegreystone
Copy link
Collaborator Author

See discussion at opentracing/opentracing-java#314. As soon as it is resolved, and we have all we need, all vendor specific tracer-stuff can be removed (ContextExtractor and friends).

@thegreystone thegreystone changed the title Get rid of dependencies to actual tracer implementations Get rid of dependencies to vendor specific tracer implementations Dec 1, 2018
@thegreystone thegreystone self-assigned this Dec 1, 2018
@thegreystone
Copy link
Collaborator Author

The opentracing-0.32.0 branch currently shows what it would look like. Sadly, we'd lose parentId as the proposal currently stands.

@thegreystone
Copy link
Collaborator Author

The thing we would lose is reconstructing the DAG directly from recording data. It would be sexy to have it (and render it), but we could, perhaps, survive.

@thegreystone
Copy link
Collaborator Author

#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant