Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repository to reflect wider scope than just observer API #6

Closed
objectiser opened this issue Jul 4, 2017 · 6 comments
Closed

Comments

@objectiser
Copy link
Contributor

As discussed in this thread (#3 (comment)) we should rename this repo to something more appropriate to cover observer and filter API.

java-patterns - too generic
java-tracer-decorator and java-tracer-wrapper - I think these are too implementation specific, and focus just on the wrapping/decorator rather than on the APIs
java-api-extensions and java-tracer-extensions - these are in the right direction, wonder if a truncated form would work - e.g. java-ext

@pavolloffay
Copy link
Collaborator

The most I like is
java-api-extensions. java-ext is not story telling at the first glance I don't know what is there.

@yurishkuro
Copy link
Contributor

why not simply use different repos?

@objectiser
Copy link
Contributor Author

@yurishkuro Was thinking that the filter/interceptor API would also use the SpanData to enable more interesting possibilities.

@yurishkuro
Copy link
Contributor

It's it worth creating intermodule dependencies because of one pojo?

@objectiser
Copy link
Contributor Author

objectiser commented Jul 4, 2017

The APIs should be in a single module, but the wrapper discussed in #5 would probably be better in a separate module.

@objectiser
Copy link
Contributor Author

@pavolloffay @felixbarny @yurishkuro As part of this issue, would like to do the following:

  • Rename the repo to java-api-extensions (as proposed by Pavol)
  • Artifact id changed to opentracing-api-extensions
  • Place interfaces into package io.opentracing.contrib.api

Any objections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants