Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dts): fix dts error when build vue2 components #2606

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Dec 4, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Transitioned dependency management for TypeScript and Vite to a catalog-based approach across multiple projects, enhancing flexibility in version resolution.
  • Chores

    • Updated package.json files for various projects to reflect the new catalog-based dependency references.
  • Documentation

    • Added a new entry for TypeScript in the catalog section of pnpm-workspace.yaml, specifying a version constraint of ~5.3.3.

Copy link

coderabbitai bot commented Dec 4, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces changes to various package.json files across multiple projects within the @opentiny organization. The primary modification involves updating the version specifications for the typescript and vite dependencies from specific version ranges to a catalog reference format. This shift indicates a move towards a centralized catalog-based dependency management approach across the projects.

Changes

File Path Change Summary
examples/openinula-docs/package.json Updated typescript from "^5.0.2" to "catalog:", and vite from "^4.0.1" to "catalog:".
examples/react-docs/package.json Updated typescript from "^5.0.2" to "catalog:", and vite to "catalog:".
examples/sites/package.json Updated typescript from "^5.0.2" to "catalog:", and vite to "catalog:".
examples/vue2.7/package.json Updated typescript from "^5.0.0" to "catalog:", vite to "catalog:", and vitest to "catalog:".
examples/vue2/package.json Updated typescript from "^5.0.0" to "catalog:", vite to "catalog:", and vitest to "catalog:".
examples/vue3/package.json Updated typescript from "^5.0.0" to "catalog:", vite to "catalog:", and vitest to "catalog:".
internals/cli/package.json Added typescript with version "catalog:" in devDependencies.
internals/unplugin-tiny-vue/package.json Updated typescript from "^5.0.0" to "catalog:", and vite from ">=4" to "catalog:".
internals/unplugin-virtual-template/package.json Updated typescript from "^5.0.0" to "catalog:", vite to "catalog:", and vitest to "catalog:".
internals/vue-vite-import/example/ts/package.json Updated typescript from "^5.0.0" to "catalog:", and vite from "^4.0.0" to "catalog:".
internals/vue-vite-import/package.json Updated typescript from "^5.0.0" to "catalog:", and added vite as "catalog:".
package.json Updated typescript from "^5.0.0" to "catalog:", and vite to "catalog:" in dependencies and overrides.
pnpm-workspace.yaml Added new entry for typescript with version ~5.3.3 in the catalog section.

Possibly related PRs

Suggested reviewers

  • kagol

Poem

🐰 In the garden of code, we hop and play,
With catalog: changes brightening the way.
Dependencies dance, no more fixed chains,
A fresh breeze of freedom, where joy remains.
Let's celebrate this shift with a cheer,
For a world of flexibility, we hold dear! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c5e56b6 and fb383f0.

📒 Files selected for processing (13)
  • examples/openinula-docs/package.json (1 hunks)
  • examples/react-docs/package.json (1 hunks)
  • examples/sites/package.json (2 hunks)
  • examples/vue2.7/package.json (1 hunks)
  • examples/vue2/package.json (1 hunks)
  • examples/vue3/package.json (1 hunks)
  • internals/cli/package.json (1 hunks)
  • internals/unplugin-tiny-vue/package.json (1 hunks)
  • internals/unplugin-virtual-template/package.json (1 hunks)
  • internals/vue-vite-import/example/ts/package.json (1 hunks)
  • internals/vue-vite-import/package.json (1 hunks)
  • package.json (2 hunks)
  • pnpm-workspace.yaml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Dec 4, 2024

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@kagol kagol merged commit c3cf26f into dev Dec 4, 2024
4 checks passed
@kagol kagol added the bug Something isn't working label Dec 4, 2024
@github-actions github-actions bot removed the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants