-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix build all components error #2602
Conversation
WalkthroughThe pull request introduces several modifications across multiple files, primarily enhancing the build process for UI components related to different Vue versions. A new design entry is added to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🔇 Additional comments (3)packages/design/smb/package.json (1)
The addition of internals/cli/src/commands/build/build-ui.ts (1)
The addition of 'design/smb' to matchList enables the build system to process the new design system module. Let's verify the design system path integration: ✅ Verification successfulThe design system path 'design/smb' is correctly integrated in build configuration Based on the build-ui.ts file content, I can verify that 'design/smb' is properly added to the 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the design system path structure and related files
# Check if the design system directory exists and has expected structure
fd --type d "design/smb" packages/
# Check for any references to the design system in build configurations
rg -l "design/smb" "internals/cli/src/**/*.ts"
Length of output: 147 Script: #!/bin/bash
# Let's verify with more precise paths and broader search
# Check if the design system directory exists anywhere in the repository
fd "design/smb"
# Search for any references to design/smb in all TypeScript files
rg -l "design/smb" "**/*.ts"
# Check the specific build configuration file content
cat "internals/cli/src/commands/build/build-ui.ts"
Length of output: 15265 packages/theme/src/old-theme-index.js (1)
The CSS variables are well-structured, following consistent naming conventions and covering all necessary design aspects (colors, typography, spacing, shadows, etc.). Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Chores
@opentiny/vue-icon
for better icon management.