-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(commmitlint): modify the commitlint tool submission limit #2526
Conversation
WalkthroughThe changes involve an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
commitlint.config.js (1)
1-6
: Consider adding more commit message rules.While setting a maximum length is good, consider adding more rules to ensure high-quality commit messages:
module.exports = { extends: ['@commitlint/config-conventional'], rules: { - 'header-max-length': [1, 'always', 150] + 'header-max-length': [1, 'always', 150], + 'body-max-line-length': [1, 'always', 100], + 'subject-case': [2, 'always', 'lower-case'], + 'type-enum': [2, 'always', [ + 'feat', 'fix', 'docs', 'style', 'refactor', + 'perf', 'test', 'build', 'ci', 'chore', 'revert' + ]] } }These additional rules will:
- Enforce line length in commit body
- Ensure consistent case in commit subjects
- Restrict commit types to a predefined set
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
commitlint.config.js
(1 hunks)
🔇 Additional comments (2)
commitlint.config.js (2)
2-2
: LGTM! Good practice using conventional commit standard.
Extending @commitlint/config-conventional
ensures adherence to the widely-adopted Conventional Commits specification.
3-5
: 🛠️ Refactor suggestion
Consider stricter enforcement and shorter limit for commit messages.
The current configuration has two potential issues:
- Using warning level (1) instead of error level (2) means developers can still submit commits exceeding the limit
- 150 characters is quite lenient - conventional git practices typically recommend 50-72 characters for better readability
Consider this stricter configuration:
rules: {
- 'header-max-length': [1, 'always', 150]
+ 'header-max-length': [2, 'always', 72]
}
Let's analyze the current commit history to understand the impact:
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit