Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds response return data #149

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

adds response return data #149

wants to merge 4 commits into from

Conversation

p-ferreira
Copy link
Contributor

  • adds return data (status and message) to wandb log event schema
  • updates wandb version to fix JSON Decode error
  • fix mock reward data issues
  • complements unit tests

@p-ferreira p-ferreira added the 1.2.1 Potential push for v1.2.1 label Sep 15, 2023
@p-ferreira p-ferreira linked an issue Sep 15, 2023 that may be closed by this pull request
Add error details in wandb logs #148
Open
@p-ferreira p-ferreira marked this pull request as ready for review September 15, 2023 15:43
steffencruz
steffencruz approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@steffencruz steffencruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left a couple of comments

openvalidators/mock.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@p-ferreira p-ferreira mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffencruz steffencruz steffencruz approved these changes

Assignees
No one assigned
Labels
1.2.1 Potential push for v1.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error details in wandb logs
2 participants
@p-ferreira @steffencruz