Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot merge lines with same relations in it when the relations have different order #9502

Open
vmicho opened this issue Feb 11, 2023 · 1 comment · May be fixed by #10089
Open

Cannot merge lines with same relations in it when the relations have different order #9502

vmicho opened this issue Feb 11, 2023 · 1 comment · May be fixed by #10089

Comments

@vmicho
Copy link

vmicho commented Feb 11, 2023

URL

No response

How to reproduce the issue?

When adding a line with relations (e.g. separate multipoly away from some feature like footpath) I cannot merge the new line with another line containing same relations, when those relations are in different order.
This should normally work as the relation list contains same elements.

example: selected are 2 connected lines (sharing point on top-left):
image

line1 relations:
image

line2 relations:
image

Workaround: Edit the relations so they are in the same order then merge option is active and merge works.
Workaround2: Commit eventual changes (or restart editor) -> the merge option is available (also the relations are now in same order)

To reproduce (simple version): just split any line with 2+ relations, select one of the lines, delete first relation, add the same relation (will be added at the end). Merge the lines (will not work).

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

version 2.24.2

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

@DujaOSM
Copy link

DujaOSM commented Feb 23, 2023

It's been like that for quite some time, and annoys the hell out of me; it was introduced with validation of relations on way merging. There's a set of related outstanding bugs - see also #8167, #9311.

bhousel added a commit to facebook/Rapid that referenced this issue Apr 29, 2024
re: #1389
re: openstreetmap/iD#10089
re: openstreetmap/iD#9502
re: openstreetmap/iD#9788

This was tricky to track down, as iD#10089 doesn't actually fix the issue
properly - really we should just not be using utilArrayIdentical with objects.

I wrote some tests to actually cover this issue and ensure that's it is fixed
correctly by comparing relation IDs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants