Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent user from adding duplicate relations #7120

Closed
jidanni opened this issue Dec 14, 2019 · 7 comments
Closed

Prevent user from adding duplicate relations #7120

jidanni opened this issue Dec 14, 2019 · 7 comments
Labels
validation An issue with the validation or Q/A code wontfix-not-a-bug Not actually a bug

Comments

@jidanni
Copy link
Contributor

jidanni commented Dec 14, 2019

Perhaps prevent the user from accidentally adding duplicate relations.
21135-0
At least during the Save Edit processing.

@jidanni
Copy link
Contributor Author

jidanni commented Dec 14, 2019

In fact after we add the first, it should be removed from the hints offered when making the second.

@jidanni
Copy link
Contributor Author

jidanni commented Dec 14, 2019

Here if I type an "A" the same item as just entered above is suggested.
14696-1

@quincylvania
Copy link
Collaborator

@jidanni Some types of relations can have the same feature as a member multiple times, such as a road that a bus route traverses twice. Boundaries don't work like that, but I'm not sure if this is a big enough problem to spend time addressing.

@quincylvania quincylvania added considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code labels Dec 16, 2019
@jidanni
Copy link
Contributor Author

jidanni commented Dec 22, 2019

Here's some more that I'm not sure how I made.
7882-1
Clicking the "工" also showed the same two at top.
Only upon saving did they finally become resolved into one.

@quincylvania
Copy link
Collaborator

@jidanni Your screenshot shows duplicate tags, not duplicate relations. Let us know if you can reproduce that problem.

@jidanni
Copy link
Contributor Author

jidanni commented Dec 26, 2019

(OK trying again today with the tags part, I found it very hard to get a duplicate tag tip. So the tags part is working OK.)

@quincylvania
Copy link
Collaborator

Closing in favor of #7648.

@quincylvania quincylvania added wontfix-not-a-bug Not actually a bug and removed considering Not Actionable - still considering if this is something we want labels Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code wontfix-not-a-bug Not actually a bug
Projects
None yet
Development

No branches or pull requests

2 participants