Add dictionaries "save as..." support #1244
Conversation
Reuse the edit menu.
Create a copy of each selected dictionary, or merge them into a new one.
Default to the configuration directory, instead of the current directory.
No editing or "saving as" until a dictionary is loaded. Note: this does not strictly prevent trying to edit a loading dictionary because the code does not filter the list of selected dictionaries before attempting to do so. But this is use case will result in the interface freezing until all selected dictionaries have finished loading (and then the editor will show up).
benoit-pierre
force-pushed
the
dictionaries_save_as
branch
from
511db21 to
8610b6e
Compare
|
Thanks for the review @user202729! 👍 |
plover/gui_qt/dictionaries_widget.py
Outdated
| for dictionary in dictionaries_list: | ||
| title = title_template.format(name=dictionary.short_path) | ||
| name, ext = os.path.splitext(os.path.basename(dictionary.path)) | ||
| default_name = default_name_template.format(name=name) | ||
| new_filename = _get_dictionary_save_name(self, title, default_name, [ext[1:]], | ||
| initial_filename=dictionary.path) | ||
| if new_filename is None: | ||
| continue | ||
| with _new_dictionary(new_filename) as d: | ||
| d.update(self._loaded_dictionaries[dictionary.path]) | ||
| need_reload = True |
There was a problem hiding this comment.
Just tried using this feature, and wondering if it makes sense when handling multiple dictionaries to remember the path that it was saved to.
I.e. instead of dictionary.path for initial_filename, do that for only the first, and then on subsequent dialogs open with where new_filename was pointing to.
I could definitely see wanting to make a copy of X, Y, Z dictionaries and hoping that they all end up in the same folder.
(I accidentally didn't realize that the path wasn't sticky and just tried to blindly "save" and it saved to the wrong folder)
OK, so right know the directory is always the config folder, but instead use that for the first one, and keep the same folder for the others? What if you do another operation? |
|
It could make a lot of sense to: default to the config folder for the first invocation, and re-use the selected file directory for other invocations (including adding dictionaries). |
|
I generally agree that caching the last-used folder would be a good idea, it would help with adding, saving, and merging dictionaries in more complex workflows. E.g. merge two dictionaries, add it to Plover, remove the other two. My suggestion was just how to improve the save multiple copies workflow, that takes it to the next level :) |
|
OK, let's do that. |
|
OK, done. |
Default to the configuration folder, and then remember and re-use on subsequent invocations.
benoit-pierre
force-pushed
the
dictionaries_save_as
branch
from
3bb260b to
3230f0d
Compare
Summary of changes
Alternative to #1149.
See commit messages for the detail of the changes.
Rational for 8dcda12, and allowing to create copies when multiple dictionaries are selected: with this PR and our support for read-only
assets:resources, I think we should consider changing the system default dictionaries definition to:This would result in:
user.jsonis (re-)created when missingThis would make updating easier for users that don't change those dictionaries. And if you really want to edit those, you can always can now easily save a copy (and addressing #726 would provide an even better alternative).
Pull Request Checklist