Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility: Fix heading structure to begin with h3? #1943

Open
openstaxalina opened this issue Sep 14, 2018 · 6 comments
Open

accessibility: Fix heading structure to begin with h3? #1943

openstaxalina opened this issue Sep 14, 2018 · 6 comments

Comments

@openstaxalina
Copy link

openstaxalina commented Sep 14, 2018

From https://drive.google.com/file/d/0BxiTbl6K_ZNRelpxRlkwYkZnb3c/view

Issue 3: The heading structure is broken
The sections have headings that identify them (1.3.1) but headings are marked such that they cannot be programmatically identified.

Example with empty headings: the structure of headings is broken and there are two empty headings

Reference to standards
1.3.1 Info and Relationships: Information, structure, and relationships conveyed through presentation can be
programmatically determined or are available in text. (Level A)
Suggestion

  • Make headings to organize an HTML page and avoid empty headings. Use an < h1 > element for the overall title, and < h2 > elements for major sections, and < h3 > elements for sub-sections.

  • Alternatively, you can use multiple < h1 > headings, but each of them has to be a heading to a separate section or article. Avoid skipping the levels of the headings, e.g. if you have < h1 >, it can only be followed by < h2 >, which can only be followed by < h3 > etc. Use Web Accessibility Toolbar for IE to find defects on your website.

@openstaxalina
Copy link
Author

Comment from Phil:
Seems like this stems from the CNXML->XHTML transform. The HTML page does not know that it will be in webview so it uses a higher heading level.

Also, as part of baking we update the heading levels so it might need to be fixed in there as well

@openstaxalina
Copy link
Author

image
image 1

@PiotrKozlowski
Copy link
Contributor

Is there any link to page from screenshot? Or should we force checking headings structure before loading content on every page?

@openstaxalina
Copy link
Author

openstaxalina commented Sep 18, 2018

@PiotrKozlowski this accessibility audit was performed on an unbaked version of Biology. I believe this is the specific page from the screenshot: https://cnx.org/contents/[email protected]:TK9ID2hI@9/Cell-Division.

I am not sure about your second question; I suggest we park it on Thursday, or you may be able to talk with @helenemccarron before.

@PiotrKozlowski
Copy link
Contributor

PiotrKozlowski commented Sep 19, 2018

Outline is different for me. Also I don't see empty headings.

There is additional heading Add pages which is not visable but it's in the outline. It's below div#add-page-modal. This should be removed. Should we create new issue for this?

Left - unbaked | right - baked
headings

@openstaxalina
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants