From fdef70980602dbf8d95836e4b52ec4ee3b0a57ca Mon Sep 17 00:00:00 2001 From: Francesco Pantano Date: Mon, 1 Apr 2024 15:00:34 +0200 Subject: [PATCH] Fix TLSInputReadyCondition When GlanceAPI's reconciler is executed, it checks for the provided Input, including TLS related info. If we're not failing (err is not nil), but the operation is still in progress, we should use the proper InputReady message as Reason instead the InitMessage. This patch fixes it and fix the condition with the proper message. Signed-off-by: Francesco Pantano --- controllers/glanceapi_controller.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/controllers/glanceapi_controller.go b/controllers/glanceapi_controller.go index b063ca5d..a1aca962 100644 --- a/controllers/glanceapi_controller.go +++ b/controllers/glanceapi_controller.go @@ -664,8 +664,8 @@ func (r *GlanceAPIReconciler) reconcileNormal(ctx context.Context, instance *gla // progress operation rather than something that failed instance.Status.Conditions.MarkUnknown( condition.TLSInputReadyCondition, - condition.InitReason, - condition.InputReadyInitMessage) + condition.RequestedReason, + condition.InputReadyWaitingMessage) return ctrlResult, nil } if hash != "" { @@ -689,8 +689,8 @@ func (r *GlanceAPIReconciler) reconcileNormal(ctx context.Context, instance *gla // progress operation rather than something that failed instance.Status.Conditions.MarkUnknown( condition.TLSInputReadyCondition, - condition.InitReason, - condition.InputReadyInitMessage) + condition.RequestedReason, + condition.InputReadyWaitingMessage) return ctrlResult, nil } configVars[tls.TLSHashName] = env.SetValue(certsHash)