Pin dependencies to avoid deps break CI #2575

pablintino · 2024-11-27T18:04:09Z

Till this commit we were not pinning the dependencies, resulting in break jobs as soon as a dependency changed underneath without notice. This commit pins all the dependencies to given known versions.

github-actions · 2024-11-27T18:04:21Z

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

softwarefactory-project-zuul · 2024-11-27T19:40:25Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/92ad4a7abb4643f8aa18879fcd3ef96c

lewisdenny

Thank you @pablintino

What about dogpile.cache and ansible-core in test-requirements.txt? Can we not pin them?

I also verified we can use ansible-core 2.15, I was concerned because we we are still using RHEL 9 default Python of 3.9, but ansible-core 2.15 supports 3.9 and is the latest release we can use:
https://github.com/ansible/ansible/blob/c89e95163fb1dceddf7abbefbb2e008aab9bef3c/setup.cfg#L40

pablintino · 2024-11-28T10:53:36Z

Thank you @pablintino

What about dogpile.cache and ansible-core in test-requirements.txt? Can we not pin them?

I also verified we can use ansible-core 2.15, I was concerned because we we are still using RHEL 9 default Python of 3.9, but ansible-core 2.15 supports 3.9 and is the latest release we can use: https://github.com/ansible/ansible/blob/c89e95163fb1dceddf7abbefbb2e008aab9bef3c/setup.cfg#L40

doh! I missed those two. The ansible-core was already pinned in the common file with 2.15.3, that we can definitely use.

softwarefactory-project-zuul · 2024-11-28T13:12:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6b1c7f875af24a8aa348c2b4d2ddbb21

lewisdenny · 2024-12-02T01:30:29Z

recheck

softwarefactory-project-zuul · 2024-12-02T03:25:49Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/75f90f7d40c044ea9ed33b7ab881ec23

lewisdenny · 2024-12-05T03:57:29Z

recheck

softwarefactory-project-zuul · 2024-12-05T05:42:29Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b750af8aa4c441469299eb427f390070

softwarefactory-project-zuul · 2024-12-10T18:11:45Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7ff599791bd84376947d38f7ee338de4

openshift-ci · 2024-12-16T12:35:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pablintino. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

softwarefactory-project-zuul · 2024-12-16T14:20:06Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6f34dda6152b467aa0b17771589dc975

softwarefactory-project-zuul · 2024-12-18T12:27:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e63d3355ad5545e1967c6bf96f2dae52

lewisdenny · 2024-12-19T03:28:49Z

@pablintino I think there is a change with the Ansible version that is effecting how the vars/default vars are picked up in the Molecule tests :/

RUNNING HANDLER [dnsmasq : Restart dnsmasq] ************************************
Wednesday 04 December 2024  23:25:30 -0500 (0:00:00.774)       0:06:05.970 ****
fatal: [instance]: FAILED! =>
  msg: |-
    The conditional check 'cifmw_libvirt_manager_dependency_packages | difference(ansible_facts.packages.keys()) | length == 0' failed. The error was: error while evaluating conditional (cifmw_libvirt_manager_dependency_packages | difference(ansible_facts.packages.keys()) | length == 0): 'cifmw_libvirt_manager_dependency_packages' is undefined. 'cifmw_libvirt_manager_dependency_packages' is undefined

    The error appears to be in '/home/zuul/src/github.com/openstack-k8s-operators/ci-framework/roles/dnsmasq/handlers/main.yml': line 17, column 3, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:


    - name: Restart dnsmasq
      ^ here

pablintino · 2024-12-26T17:11:40Z

@pablintino I think there is a change with the Ansible version that is effecting how the vars/default vars are picked up in the Molecule tests :/

RUNNING HANDLER [dnsmasq : Restart dnsmasq] ************************************
Wednesday 04 December 2024  23:25:30 -0500 (0:00:00.774)       0:06:05.970 ****
fatal: [instance]: FAILED! =>
  msg: |-
    The conditional check 'cifmw_libvirt_manager_dependency_packages | difference(ansible_facts.packages.keys()) | length == 0' failed. The error was: error while evaluating conditional (cifmw_libvirt_manager_dependency_packages | difference(ansible_facts.packages.keys()) | length == 0): 'cifmw_libvirt_manager_dependency_packages' is undefined. 'cifmw_libvirt_manager_dependency_packages' is undefined

    The error appears to be in '/home/zuul/src/github.com/openstack-k8s-operators/ci-framework/roles/dnsmasq/handlers/main.yml': line 17, column 3, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:


    - name: Restart dnsmasq
      ^ here

@lewisdenny Guess what, it only fails in the first run. Manually running it for another time makes the test pass.

softwarefactory-project-zuul · 2024-12-26T17:19:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f53b5f48bb2e41468db72948f1ccb1cb

softwarefactory-project-zuul · 2024-12-30T15:23:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/99d7dd00898646b79885c26c135f2b8d

softwarefactory-project-zuul · 2024-12-30T19:02:19Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9fa177d72ba643faa6fb65ffdce79fc6

pablintino · 2024-12-31T06:51:28Z

recheck

softwarefactory-project-zuul · 2024-12-31T08:23:00Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a856a5258d24591beff004d53ba020e

Till this commit we were not pinning the dependencies, resulting in break jobs as soon as a dependency changed underneath without notice. This commit pins all the dependencies to given known versions.

frenzyfriday · 2025-01-01T22:30:14Z

/lgtm
The testproject, as I remember, passed in the end

github-actions bot marked this pull request as draft November 27, 2024 18:04

openshift-ci bot added the do-not-merge/work-in-progress label Nov 27, 2024

pablintino marked this pull request as ready for review November 27, 2024 18:04

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 27, 2024

pablintino added the do-not-merge/hold label Nov 27, 2024

lewisdenny requested changes Nov 28, 2024

View reviewed changes

pablintino force-pushed the pin-version branch from 47b1cc2 to d09feda Compare November 28, 2024 10:50

pablintino force-pushed the pin-version branch from d09feda to 224fb3f Compare December 10, 2024 15:35

pablintino force-pushed the pin-version branch from 224fb3f to 0173d91 Compare December 16, 2024 12:35

pablintino force-pushed the pin-version branch from 0173d91 to d0973db Compare December 18, 2024 10:18

pablintino force-pushed the pin-version branch from d0973db to cfb69d3 Compare December 26, 2024 15:46

pablintino force-pushed the pin-version branch from cfb69d3 to 58c9008 Compare December 30, 2024 13:44

pablintino force-pushed the pin-version branch 2 times, most recently from 9425a75 to 528efdd Compare December 30, 2024 17:23

pablintino force-pushed the pin-version branch from 528efdd to 9835da5 Compare December 30, 2024 17:23

Pin cifmw dependencies

1ba4246

Till this commit we were not pinning the dependencies, resulting in break jobs as soon as a dependency changed underneath without notice. This commit pins all the dependencies to given known versions.

pablintino force-pushed the pin-version branch from 9835da5 to 1ba4246 Compare December 31, 2024 10:51

github-actions bot added the Ready For Review label Dec 31, 2024

openshift-ci bot assigned frenzyfriday Jan 1, 2025

openshift-ci bot added the lgtm label Jan 1, 2025

frenzyfriday approved these changes Jan 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin dependencies to avoid deps break CI #2575

Pin dependencies to avoid deps break CI #2575

pablintino commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

softwarefactory-project-zuul bot commented Nov 27, 2024

lewisdenny left a comment

pablintino commented Nov 28, 2024

softwarefactory-project-zuul bot commented Nov 28, 2024

lewisdenny commented Dec 2, 2024

softwarefactory-project-zuul bot commented Dec 2, 2024

lewisdenny commented Dec 5, 2024

softwarefactory-project-zuul bot commented Dec 5, 2024

softwarefactory-project-zuul bot commented Dec 10, 2024

openshift-ci bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 18, 2024

lewisdenny commented Dec 19, 2024

pablintino commented Dec 26, 2024

softwarefactory-project-zuul bot commented Dec 26, 2024

softwarefactory-project-zuul bot commented Dec 30, 2024

softwarefactory-project-zuul bot commented Dec 30, 2024

pablintino commented Dec 31, 2024

softwarefactory-project-zuul bot commented Dec 31, 2024

frenzyfriday commented Jan 1, 2025

Pin dependencies to avoid deps break CI #2575

Are you sure you want to change the base?

Pin dependencies to avoid deps break CI #2575

Conversation

pablintino commented Nov 27, 2024

github-actions bot commented Nov 27, 2024

softwarefactory-project-zuul bot commented Nov 27, 2024

lewisdenny left a comment

Choose a reason for hiding this comment

pablintino commented Nov 28, 2024

softwarefactory-project-zuul bot commented Nov 28, 2024

lewisdenny commented Dec 2, 2024

softwarefactory-project-zuul bot commented Dec 2, 2024

lewisdenny commented Dec 5, 2024

softwarefactory-project-zuul bot commented Dec 5, 2024

softwarefactory-project-zuul bot commented Dec 10, 2024

openshift-ci bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 18, 2024

lewisdenny commented Dec 19, 2024

pablintino commented Dec 26, 2024

softwarefactory-project-zuul bot commented Dec 26, 2024

softwarefactory-project-zuul bot commented Dec 30, 2024

softwarefactory-project-zuul bot commented Dec 30, 2024

pablintino commented Dec 31, 2024

softwarefactory-project-zuul bot commented Dec 31, 2024

frenzyfriday commented Jan 1, 2025