-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the VM UUID instead of some other randomly value #2332
Conversation
Until now, config_drive was using a random UUID built using the vm name. It makes tracking slightly more difficult. This PR reorganize some tasks so that we get the VM UUID earlier. It also removes the XML parsing to rely on `virsh domuuid` instead, making it stronger and safer. The UUID is then injected in the config_drive role directly.
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cccb3d74906d4a7e8015427aee33249b ❌ openstack-k8s-operators-content-provider FAILURE in 5m 09s |
recheck |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Until now, config_drive was using a random UUID built using the vm name.
It makes tracking slightly more difficult.
This PR reorganize some tasks so that we get the VM UUID earlier. It
also removes the XML parsing to rely on
virsh domuuid
instead, makingit stronger and safer.
The UUID is then injected in the config_drive role directly.