Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the VM UUID instead of some other randomly value #2332

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

cjeanner
Copy link
Collaborator

Until now, config_drive was using a random UUID built using the vm name.
It makes tracking slightly more difficult.

This PR reorganize some tasks so that we get the VM UUID earlier. It
also removes the XML parsing to rely on virsh domuuid instead, making
it stronger and safer.

The UUID is then injected in the config_drive role directly.

Until now, config_drive was using a random UUID built using the vm name.
It makes tracking slightly more difficult.

This PR reorganize some tasks so that we get the VM UUID earlier. It
also removes the XML parsing to rely on `virsh domuuid` instead, making
it stronger and safer.

The UUID is then injected in the config_drive role directly.
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cccb3d74906d4a7e8015427aee33249b

openstack-k8s-operators-content-provider FAILURE in 5m 09s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 51s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 06s
✔️ build-push-container-cifmw-client SUCCESS in 22m 16s
cifmw-molecule-libvirt_manager FAILURE in 12m 20s
cifmw-molecule-reproducer FAILURE in 4m 37s

@cjeanner
Copy link
Collaborator Author

recheck

@cjeanner cjeanner marked this pull request as ready for review September 10, 2024 10:59
@cjeanner cjeanner requested a review from hjensas September 10, 2024 11:00
@hjensas
Copy link
Contributor

hjensas commented Sep 10, 2024

/lgtm

@raukadah
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 28b92b9 into main Sep 12, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the libvirt_manager/config_drive-uuid branch September 12, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants