Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "backup" for config_drive generated files #2330

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

cjeanner
Copy link
Collaborator

While we keep failing in case of file changes, we might want to know
what changed in those files over a re-run.
Enabling the "backup" feature ensures we are able to spot the
differences and adjust our runs if needed.

While we keep failing in case of file changes, we might want to know
what changed in those files over a re-run.
Enabling the "backup" feature ensures we are able to spot the
differences and adjust our runs if needed.
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cjeanner cjeanner marked this pull request as ready for review September 10, 2024 06:40
@cjeanner cjeanner requested a review from hjensas September 10, 2024 06:40
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@cescgina cescgina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4330f5d into main Sep 10, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the config_drive/backup-data branch September 10, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants