-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we configure any "managed" VM #2327
Ensure we configure any "managed" VM #2327
Conversation
Skipping CI for Draft Pull Request. |
/trigger github-experimental |
afa6cbd
to
a874a16
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/30032451f926479e951c1e48599a1111 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 16s |
UNtile now, we didn't generate any config drive for VM that weren't started, even though we wanted them managed. This patch corrects the issue, and also ensure we don't rely on SSH to configure anything on the VMs. We just keep plain SSH accesses for OCP/CRC, since they can't rely on cloud-init.
a874a16
to
c6a7fa8
Compare
we need this for the adoption infra |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cescgina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
UNtile now, we didn't generate any config drive for VM that weren't
started, even though we wanted them managed.
This patch corrects the issue, and also ensure we don't rely on SSH to
configure anything on the VMs.
We just keep plain SSH accesses for OCP/CRC, since they can't rely on
cloud-init.