Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we configure any "managed" VM #2327

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

cjeanner
Copy link
Collaborator

@cjeanner cjeanner commented Sep 9, 2024

UNtile now, we didn't generate any config drive for VM that weren't
started, even though we wanted them managed.

This patch corrects the issue, and also ensure we don't rely on SSH to
configure anything on the VMs.

We just keep plain SSH accesses for OCP/CRC, since they can't rely on
cloud-init.

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cjeanner
Copy link
Collaborator Author

cjeanner commented Sep 9, 2024

/trigger github-experimental

@cjeanner cjeanner force-pushed the libvirt_manager/enable-cloud-init-stopped branch from afa6cbd to a874a16 Compare September 9, 2024 18:28
@cjeanner cjeanner marked this pull request as ready for review September 9, 2024 18:29
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/30032451f926479e951c1e48599a1111

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 04s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 19m 42s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 07s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 33s
✔️ build-push-container-cifmw-client SUCCESS in 22m 21s
cifmw-molecule-libvirt_manager FAILURE in 16m 51s
✔️ cifmw-molecule-reproducer SUCCESS in 20m 22s

UNtile now, we didn't generate any config drive for VM that weren't
started, even though we wanted them managed.

This patch corrects the issue, and also ensure we don't rely on SSH to
configure anything on the VMs.

We just keep plain SSH accesses for OCP/CRC, since they can't rely on
cloud-init.
@cjeanner cjeanner force-pushed the libvirt_manager/enable-cloud-init-stopped branch from a874a16 to c6a7fa8 Compare September 10, 2024 08:08
@cescgina
Copy link
Contributor

we need this for the adoption infra

@cescgina
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3c88f0b into main Sep 10, 2024
4 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the libvirt_manager/enable-cloud-init-stopped branch September 10, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants