Use cifmw_architecture_scenario to set proper automation file #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
cescgina
reviewed
Aug 27, 2024
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/582e9425af4a460c9e9088e5ad156d37 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 47s |
raukadah
force-pushed
the
split_default_automation
branch
from
7bad0da to
a1d4dd5
Compare
|
/trigger github-experimental |
cjeanner
reviewed
Aug 29, 2024
raukadah
force-pushed
the
split_default_automation
branch
from
a1d4dd5 to
9db8391
Compare
raukadah
force-pushed
the
split_default_automation
branch
from
9db8391 to
c3a0c54
Compare
|
/trigger github-experimental |
cjeanner
requested changes
Aug 29, 2024
openstack-k8s-operators/architecture#375 splits the default vars into different scenario files. We need to fix the reproducer to adapt this change. This pull-request uses cifmw_architecture_scenario to set proper automation file. It drops cifmw_arch_automation_file params from scenario files. Depends-On: openstack-k8s-operators/architecture#375 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
raukadah
force-pushed
the
split_default_automation
branch
from
c3a0c54 to
3273071
Compare
raukadah
added a commit
to raukadah/architecture
that referenced
this pull request
Sep 3, 2024
openstack-k8s-operators#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
raukadah
changed the title
raukadah
added a commit
to raukadah/architecture
that referenced
this pull request
Sep 3, 2024
openstack-k8s-operators#375 splits the default vars into different scenario files. We need to follow similar pattern for bgp_dt01 also. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
raukadah
added a commit
to raukadah/architecture
that referenced
this pull request
Sep 3, 2024
openstack-k8s-operators#375 splits the default vars into different scenario files. We need to follow similar pattern for bgp_dt01 also. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
cjeanner
pushed a commit
to openstack-k8s-operators/architecture
that referenced
this pull request
Sep 3, 2024
#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
softwarefactory-project-zuul bot
added a commit
to openstack-k8s-operators/architecture
that referenced
this pull request
Sep 4, 2024
Move bgp_dt01 into its own automation file #375 splits the default vars into different scenario files. We need to follow similar pattern for bgp_dt01 also. Depends-On: openstack-k8s-operators/ci-framework#2267 Reviewed-by: Marios Andreou
cjeanner
pushed a commit
to raukadah/architecture
that referenced
this pull request
Sep 4, 2024
openstack-k8s-operators#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
cjeanner
pushed a commit
to openstack-k8s-operators/architecture
that referenced
this pull request
Sep 4, 2024
#375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
softwarefactory-project-zuul bot
added a commit
to openstack-k8s-operators/architecture
that referenced
this pull request
Sep 4, 2024
Drop default.yaml file #375 splits the default vars into different scenario files. openstack-k8s-operators/ci-framework#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. So we are no longer needing default.yaml file. Depends-On: openstack-k8s-operators/ci-framework#2292 Reviewed-by: Cédric Jeanneret
eduolivares
pushed a commit
to eduolivares/architecture
that referenced
this pull request
Sep 9, 2024
openstack-k8s-operators#375 splits the default vars into different scenario files. We need to follow similar pattern for bgp_dt01 also. Depends-On: openstack-k8s-operators/ci-framework#2267 Signed-off-by: Chandan Kumar (raukadah) <[email protected]> (cherry picked from commit 116ab90)
|
/cherrypick 18.0.0-proposed |
|
@raukadah: #2267 failed to apply on top of branch "18.0.0-proposed": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
raukadah
added a commit
that referenced
this pull request
Sep 12, 2024
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
raukadah
added a commit
that referenced
this pull request
Sep 12, 2024
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ci-framework
that referenced
this pull request
Sep 12, 2024
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. openstack-k8s-operators#2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
openstack-k8s-operators/architecture#383 drops defaults.yaml scenario file in favor of openstack-k8s-operators/architecture#375. #2267 suggests to use Use cifmw_architecture_scenario to set proper automation file. Whereever default.yaml is used, the job broke. This pr fixes the same using cifmw_architecture_scenario file. Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openstack-k8s-operators/architecture#375 splits the default vars into different scenario files. We need to fix the reproducer to adapt this change.
This pull-request uses cifmw_architecture_scenario to set proper automation file.
It drops cifmw_arch_automation_file params from scenario files.
Depends-On: openstack-k8s-operators/architecture#375
[VA HCI test results](VA HCI test results: https://review.rdoproject.org/r/c/tripleo-downstream-trigger-nested-virt/+/54197/1#message-8ff37ab5d3092b1dedde50f1c39440965673c825)