Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce control plane testing. #2169

Conversation

sathlan
Copy link
Contributor

@sathlan sathlan commented Jul 26, 2024

Just before starting the update and for the entire update, this
continuously:

  1. creates a vm;
  2. attach a volume (optional) and a fip to ip
  3. ssh to it
  4. destroy it
  5. restart from 1.

This give a good level of confidence that the openstack API is still
reachable during the update.


As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@github-actions github-actions bot marked this pull request as draft July 26, 2024 15:55
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@sathlan sathlan added the minor update Changes for minor update automation label Jul 26, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a95c68f13cd74c1489e2ef3e90153dab

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 33m 07s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 16m 15s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 10m 29s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 54s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 15s
✔️ cifmw-molecule-update SUCCESS in 4m 40s

@sathlan sathlan force-pushed the control-plane-testing-update branch from f9bf9d6 to 0229713 Compare July 26, 2024 17:30
@sathlan sathlan marked this pull request as ready for review July 26, 2024 17:32
@sathlan sathlan force-pushed the control-plane-testing-update branch from 0229713 to 2064ff9 Compare August 26, 2024 13:37
Just before starting the update and for the entire update, this
continuously:
1. creates a vm;
2. attach a volume (optional) and a fip to ip
3. ssh to it
4. destroy it
5. restart from 1.

This give a good level of confidence that the openstack API is still
reachable during the update.
@raukadah
Copy link
Contributor

raukadah commented Sep 9, 2024

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c006610 into openstack-k8s-operators:main Sep 10, 2024
5 checks passed
@sathlan
Copy link
Contributor Author

sathlan commented Sep 10, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@sathlan: #2169 failed to apply on top of branch "18.0.0-proposed":

Applying: Introduce control plane testing.
Using index info to reconstruct a base tree...
M	roles/update/tasks/create_test_files.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/update/tasks/create_test_files.yml
CONFLICT (content): Merge conflict in roles/update/tasks/create_test_files.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Introduce control plane testing.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sathlan
Copy link
Contributor Author

sathlan commented Sep 16, 2024

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@sathlan: new pull request created: #2354

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm minor update Changes for minor update automation Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants