From d758d6dde3cf7af0d9f1bf3e90c80ca83c14f7b5 Mon Sep 17 00:00:00 2001
From: Felipe Reyes <felipe.reyes@canonical.com>
Date: Tue, 26 Nov 2024 03:34:35 -0800
Subject: [PATCH] Pin websockets library (#669)

* Pin websockets library

Set upper bound for websockets until libjuju is compatible with newer
versions.

See https://github.com/juju/python-libjuju/pull/1208

* Migrate to actions/upload-artifact@v4
---
 .github/workflows/tox.yaml | 2 +-
 requirements.txt           | 4 ++++
 setup.py                   | 3 +++
 test-requirements.txt      | 4 ++++
 4 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/tox.yaml b/.github/workflows/tox.yaml
index 7f12a6a0..b77a756d 100644
--- a/.github/workflows/tox.yaml
+++ b/.github/workflows/tox.yaml
@@ -108,7 +108,7 @@ jobs:
         juju-crashdump -m $model -o logs/
     - name: upload logs on failure
       if: failure()
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: test-run-logs-and-crashdump
         path: logs/
diff --git a/requirements.txt b/requirements.txt
index 9668b535..9e0cde38 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -35,3 +35,7 @@ sphinx
 sphinxcontrib-asyncio
 # https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
 macaroonbakery!=1.3.3
+
+# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
+# newer versions. See https://github.com/juju/python-libjuju/pull/1208
+websockets<13.0.0
diff --git a/setup.py b/setup.py
index 2ce65a1b..91739dda 100644
--- a/setup.py
+++ b/setup.py
@@ -43,6 +43,9 @@
 
     # https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
     'macaroonbakery != 1.3.3',
+    # NOTE(freyes): Set upper bound for websockets until libjuju is compatible
+    # with newer versions. See https://github.com/juju/python-libjuju/pull/1208
+    'websockets<13.0.0',
 ]
 if os.environ.get("TEST_JUJU3"):
     install_require.append('juju')
diff --git a/test-requirements.txt b/test-requirements.txt
index 3c66eb3d..5557c6f9 100644
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -16,6 +16,10 @@ keystoneauth1
 oslo.config
 python-novaclient
 tenacity>8.2.0
+# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
+# newer versions. See https://github.com/juju/python-libjuju/pull/1208
+websockets<13.0.0
+
 # To force the installation of an specific version of libjuju use a constraints
 # file, e.g.: `env PIP_CONSTRAINTS=./constraints-juju31.txt tox -e func-target`
 juju