script voting assignment

[andrewdmcleod]

script voting assignment to charmers for their review to speed up vote/review process

[ryan-beisner]

It's not clear to me what this means. Please expand on this issue / feature request. Thank you.

[andrewdmcleod]

At the end of the release process there was a requirement to have individuals +1 the PRs (not necessarily approvers) and there was confusion on who was doing it, which they were doing, whether they were duplicating it, etc.

It would make sense to have a simple script into which you input names (emails) which generates PR URLs for those email-users to click on and +1 (while there was not a huge amount of PRs, there may also be more in future). This script could also include an 'expected diff' since on one hand we have already reviewed the changes to get to this point, and the +1 is in essence a tip of the hat, there should be SOME sanity check. This expected diff "example" should be minimal since it is just a branch/release switch/cut.

This could be part of the larger "release" script which was suggested in another issue.

[ryan-beisner]

Ah ok. So, we discussed whether or not to pursue automatic CR voting on the batch and decided against it. ie. The bot can vote on tests, but should not do code-review voting.

Whether a human is comfortable with scripting an iterative code-review plus-vote is a different debate, and may or may not be desired per-individual.

I don't think we should script it.