Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quictestlib to not require tserver #931

Open
mattcaswell opened this issue Nov 25, 2024 · 0 comments
Open

Update quictestlib to not require tserver #931

mattcaswell opened this issue Nov 25, 2024 · 0 comments

Comments

@mattcaswell
Copy link
Member

On the feature/quic-server branch we should update functions such as qtest_create_quic_objects in test/helpers/quictestlib.c to not require tserver, but instead use the normal QUIC API.

tserver only exists because we originally only had client side code, and we needed a simple server implementation to tun our tests against. Now the the feature/quic-server branch has a full server implementation in it we should be using that for our tests.

This issue is to provide the necessary test framework support to enable new tests in quicapitest.c to be written without any dependence on tserver. A separate issue will be created to convert existing tests to remove the dependency on tserver.

Eventually we should be able to remove tserver completely.

To resolve this issue we should:

  • Review all functions in test/helpers/quictestlib.c that use QUIC_TSERVER
  • For all functions we should implement an alternative that does not have a dependence on QUIC_TSERVER
  • We should convert 1 or 2 tests in quicapitest.c to use the new functions to confirm that they work as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

1 participant