Merge pull request #630 from opensrp/jsonfrominteracter-memory-leak

fix memory leaks in NativeRadioButtonFactory

android-json-form-wizard/src/main/java/com/vijay/jsonwizard/fragments/JsonFormFragment.java

@@ -824,6 +824,12 @@ public boolean onMenuItemClick(MenuItem item) {
         return presenter.onMenuItemClick(item);
     }
 
+    @Override
+    public void onStop() {
+        super.onStop();
+        presenter.cleanUp();
+    }
+
     protected class BottomNavigationListener implements View.OnClickListener {
         @Override
         public void onClick(View view) {

android-json-form-wizard/src/main/java/com/vijay/jsonwizard/interactors/JsonFormInteractor.java

@@ -278,4 +278,10 @@ public final Set<String> getDefaultTranslatableStepFields() {
         return defaultTranslatableStepFields;
     }
 
+    public void cleanUp() {
+        if(map.get(JsonFormConstants.NATIVE_RADIO_BUTTON) != null){
+            NativeRadioButtonFactory nativeRadioButtonFactory = (NativeRadioButtonFactory) map.get(JsonFormConstants.NATIVE_RADIO_BUTTON);
+            nativeRadioButtonFactory.cleanUp();
+        }
+    }
 }

android-json-form-wizard/src/main/java/com/vijay/jsonwizard/presenters/JsonFormFragmentPresenter.java

@@ -1270,5 +1270,6 @@ private void addRules(JSONObject jsonObject, Set<String> ruleFiles) {
 
     public void cleanUp() {
         cleanupAndExit = true;
+        mJsonFormInteractor.cleanUp();
     }
 }

android-json-form-wizard/src/main/java/com/vijay/jsonwizard/widgets/NativeRadioButtonFactory.java

@@ -890,4 +890,13 @@ public Set<String> getCustomTranslatableWidgetFields() {
         customTranslatableWidgetFields.add(JsonFormConstants.LABEL_INFO_TITLE);
         return customTranslatableWidgetFields;
     }
+
+    public void cleanUp(){
+        this.context = null;
+        this.formFragment = null;
+        this.radioButton = null;
+        this.extraInfoTextView = null;
+        this.specifyTextView = null;
+        this.reasonsTextView = null;
+    }
 }

gradle.properties

@@ -1,4 +1,4 @@
-VERSION_NAME=2.1.16-SNAPSHOT
+VERSION_NAME=2.1.17-SNAPSHOT
 VERSION_CODE=1
 GROUP=org.smartregister
 POM_SETTING_DESCRIPTION=OpenSRP Client Native Form Json Wizard