From 88a0c20bc7ae868041f0b6f0db47a1abdcadebbe Mon Sep 17 00:00:00 2001 From: Benjamin Gilbert Date: Fri, 29 Sep 2023 03:38:43 -0500 Subject: [PATCH 1/3] Revert "docs/testsuite: document `dicom` feature flag" libdicom is now required. This reverts commit 2bd2fe46b3e9c2e3e923536feaf96835a75b04da. Signed-off-by: Benjamin Gilbert --- docs/testsuite/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/testsuite/index.md b/docs/testsuite/index.md index 74bfbd1..3a28314 100644 --- a/docs/testsuite/index.md +++ b/docs/testsuite/index.md @@ -139,8 +139,8 @@ original slide (e.g., if OpenSlide falls back to `generic-tiff`), change `vendor` to the new string or `null` for NULL. If the test should only be run if particular OpenSlide dependencies are -available, set `requires` to a list of feature flags. Currently the only -defined feature flag is `dicom`. +available, set `requires` to a list of feature flags. Currently there are +no defined feature flags. Pack the test: From 7b5d9e38aa54f7ac40694121940e4c8fa4974d86 Mon Sep 17 00:00:00 2001 From: Benjamin Gilbert Date: Mon, 2 Oct 2023 22:29:44 -0500 Subject: [PATCH 2/3] docs/testsuite: document new support for copying test case files Signed-off-by: Benjamin Gilbert --- docs/testsuite/index.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/testsuite/index.md b/docs/testsuite/index.md index 3a28314..a4c7d1b 100644 --- a/docs/testsuite/index.md +++ b/docs/testsuite/index.md @@ -209,6 +209,11 @@ generate: ? "CMU-1-40x - 2010-01-12 13.24.05(1,1).jpg" : "jpegtran -restart 256B -outfile %(out)s %(in)s" +# Copy test case files during unpack. +copy: + ? DCM_0_copy.dcm + : DCM_0.dcm + # Rename or move test case files during unpack. rename: ? "CMU-1-40x - 2010-01-12 13.24.05(1,1).jpg" From f3c52d0dce284344f433c329c9605c9162c61e97 Mon Sep 17 00:00:00 2001 From: Benjamin Gilbert Date: Wed, 4 Oct 2023 07:21:44 -0500 Subject: [PATCH 3/3] formats/dicom: link to libdicom GitHub page instead of docs The libdicom docs are mainly API documentation, and don't actually say where to get the library. Signed-off-by: Benjamin Gilbert --- formats/dicom/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/formats/dicom/index.md b/formats/dicom/index.md index 8440724..4c5760d 100644 --- a/formats/dicom/index.md +++ b/formats/dicom/index.md @@ -28,8 +28,8 @@ OpenSlide will detect a file as DICOM if: ## File Organization -OpenSlide uses [libdicom](https://libdicom.readthedocs.io/) to parse and -load DICOM files. +OpenSlide uses [libdicom](https://github.com/ImagingDataCommons/libdicom/) +to parse and load DICOM files. OpenSlide non-recursively scans the containing directory for other DICOM files with the same _Series Instance UID_ attribute value as the specified