Small fixes #294
Merged
Small fixes #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested-by: Jan Harkes <[email protected]> Signed-off-by: Benjamin Gilbert <[email protected]>
Decorate methods with '@AbstractMethod' to prevent instantiation unless all abstract methods and properties are overridden. Signed-off-by: Jan Harkes <[email protected]> Signed-off-by: Benjamin Gilbert <[email protected]>
It was added in 1.2.0, so any older third-party subclass may not implement the method. In addition, most subclasses will want this method to do nothing, matching ImageSlide's implementation. Make the default implementation do nothing and remove the method override from ImageSlide. Signed-off-by: Benjamin Gilbert <[email protected]>
openslide_set_cache() doesn't generate any errors, but that's an implementation detail, and for consistency we should check that an error wasn't previously set. Signed-off-by: Jan Harkes <[email protected]> Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on, and supersedes, #243.
cc @jaharkes