Add type hints to _convert and lowlevel; add type-checking infrastructure
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing items for the purpose of re-exporting them, use "from X import Y as Y" syntax so type checkers know that re-export is intended. Signed-off-by: Benjamin Gilbert <[email protected]>
This seems slightly cleaner, especially once typechecking is added. Signed-off-by: Benjamin Gilbert <[email protected]>
Run mypy during pre-commit. For now, only type-check setup.py and _version.py. We will support type checking on Python >= 3.10. 3.9 has too many limitations to be worth supporting. Signed-off-by: Benjamin Gilbert <[email protected]>
Because of the underscore, _convert is (correctly) not part of the external API, so this is for internal typechecking purposes only. The .pyi file will still be installed though. Signed-off-by: Benjamin Gilbert <[email protected]>
Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only support type-checking on Python 3.10+, at least for now.
Prep for #260. I'll rebase that PR after this lands.