Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: small cleanups #240

Merged
merged 2 commits into from
Nov 15, 2023
Merged

pre-commit: small cleanups #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c0e776
pre-commit: move black settings to pyproject.toml
bgilbert Nov 15, 2023
0c4a99c
pre-commit: specify Python target versions to black
bgilbert Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/python-bump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

- Update Git main
- [ ] `git checkout main`
- [ ] Add classifier for new Python version to `pyproject.toml'
- [ ] In `pyproject.toml`, add classifier for new Python version and update `tool.black.target-version`
- [ ] Add new Python version to lists in `.github/workflows/python.yml`
- [ ] Commit and open a PR
- [ ] Merge the PR when CI passes
Expand Down
2 changes: 0 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ repos:
hooks:
- id: black
name: Format python code with black
language_version: python3
args: ["--skip-string-normalization"]

- repo: https://github.com/asottile/blacken-docs
rev: 1.16.0
Expand Down
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ packages = ["openslide"]
[tool.setuptools.dynamic]
version = {attr = "openslide._version.__version__"}

[tool.black]
skip-string-normalization = true
target-version = ["py38", "py39", "py310", "py311", "py312"]

[tool.isort]
profile = "black"
force_sort_within_sections = true
Expand Down