workflows: expect builder container repo/digest as parameter #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expect the container repo and image digest as a parameter to the windows workflow. This allows the caller (particularly the nightly builder) to exercise full control over the container image, and ensures that every job in the workflow uses the same image. Add a find-container-digest action that can be invoked from callers' setup jobs to compute the parameter. This is a breaking change for callers of the windows workflow in other repos. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
bgilbert
added a commit
to bgilbert/openslide-builds
that referenced
this pull request
Sep 25, 2023
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
sammaxwellxyz
pushed a commit
to sammaxwellxyz/openslide-isyntax-integration
that referenced
this pull request
Dec 10, 2024
Adapt for openslide/openslide-bin#129. Signed-off-by: Benjamin Gilbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect the container repo and image digest as a parameter to the
windowsworkflow. This allows the caller (particularly the nightly builder) to exercise full control over the container image, and ensures that every job in the workflow uses the same image.Add a
find-container-digestaction that can be invoked from callers' setup jobs to compute the parameter.This is a breaking change for callers of the
windowsworkflow in other repos.