Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ODH operator to Go 1.22 #59338

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented Nov 28, 2024

@openshift-ci openshift-ci bot requested review from biswassri and LaVLaS November 28, 2024 16:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@grdryn
Copy link
Member Author

grdryn commented Nov 28, 2024

/cc @zdtsw @lburgazzoli @ykaliuta
/uncc @LaVLaS

@openshift-ci openshift-ci bot requested review from lburgazzoli, ykaliuta and zdtsw and removed request for LaVLaS November 28, 2024 16:37
@grdryn
Copy link
Member Author

grdryn commented Nov 28, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@grdryn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grdryn
Copy link
Member Author

grdryn commented Nov 28, 2024

/pj-rehearse abort

@openshift-ci-robot
Copy link
Contributor

@grdryn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grdryn grdryn force-pushed the odh-operator-go1.22 branch from a570b08 to f2946d7 Compare November 28, 2024 17:08
@grdryn
Copy link
Member Author

grdryn commented Nov 28, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@grdryn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grdryn grdryn force-pushed the odh-operator-go1.22 branch from f2946d7 to 0856e47 Compare December 5, 2024 16:33
@grdryn
Copy link
Member Author

grdryn commented Dec 5, 2024

@zdtsw @VaishnaviHire I've changed this to target the main branch now, since I understand that that's the new development branch. I'll replace opendatahub-io/opendatahub-operator#1400 with an equivalent targeting main also, but I believe this would be the first step.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@grdryn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-opendatahub-operator-main-ci-index opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-images opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-e2e opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
pull-ci-opendatahub-io-opendatahub-operator-main-opendatahub-operator-pr-image-mirror opendatahub-io/opendatahub-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@grdryn
Copy link
Member Author

grdryn commented Dec 5, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@grdryn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@grdryn
Copy link
Member Author

grdryn commented Dec 5, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@grdryn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grdryn, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@grdryn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cf76422 into openshift:master Dec 6, 2024
17 checks passed
@zdtsw
Copy link
Member

zdtsw commented Dec 6, 2024

grrrrrrrrrrrr. so i suddenly have the "permission to approve"?

@grdryn grdryn deleted the odh-operator-go1.22 branch December 6, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants