Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-4079,CONSOLE-4080: Address tech debt in GenericSecretForm and KeyValueEntryForm components #14520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mylanos
Copy link
Contributor

@Mylanos Mylanos commented Nov 20, 2024

No description provided.

…e the typing definitions, rename to OpaqueSecretFormEntry
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2024

@Mylanos: This pull request references CONSOLE-4079 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

This pull request references CONSOLE-4080 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2024
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Nov 20, 2024
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mylanos
Once this PR has been reviewed and has the lgtm label, please assign christoph-jerolimov for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…t, decouple some of the functions to utils file, rename the component to OpaqueSecretForm.tsx, consolidate typings
@Mylanos Mylanos force-pushed the CONSOLE-4079-CONSOLE-4080-refactor-keyvalue-and-generic-secret-form branch from 2ab4204 to 7de2976 Compare November 21, 2024 15:02
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@Mylanos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 7de2976 link true /test e2e-gcp-console
ci/prow/okd-scos-e2e-aws-ovn 7de2976 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants