Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-4269: add custom ConsolePlugin resource details page #14487

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Nov 12, 2024

Includes changes from #14374, which should merge first. Note #14374 includes a bug that needs to be addressed where not Loaded plugins do not appear in the Console plugins list.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.08.36.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

Screen.Recording.2024-11-12.at.3.52.54.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk labels Nov 12, 2024
@rhamilto rhamilto changed the title CONSOLE-4269: add custom ConsolePlugin resource details page [WIP] CONSOLE-4269: add custom ConsolePlugin resource details page Nov 12, 2024
@openshift-ci openshift-ci bot added component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 12, 2024
/**
* An optional description that will appear in the title popover.
*/
description?: string;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @TheRealJon. If description isn't supplied, the popover is populated with a description from the resource, which likely doesn't make sense, especially in cases like this where the item isn't in the schema.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 12, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • fix failing useTelemetry.spec.ts unit test | @vojtechszocs, mind taking a look?
  • improve Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?
  • add Version and Description below Display Name since they're included in the list view? | @jhadvig, WDYT?
Screen.Recording.2024-11-12.at.3.52.54.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto force-pushed the CONSOLE-4269 branch 2 times, most recently from ce82a9b to be219d6 Compare November 13, 2024 18:40
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?
  • add Version and Description below Display Name since they're included in the list view? | @jhadvig, WDYT?
Screen.Recording.2024-11-12.at.3.52.54.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto
Copy link
Member Author

@vojtechszocs, I removed the changes to useTelemetry.ts from this PR since they are unrelated the scope of the story and opened a bug to address.

const labels = enabled ? t('console-app~Enabled') : t('console-app~Disabled');

return (
<>
{consoleOperatorConfig && canPatchConsoleOperatorConfig ? (
{consoleOperatorConfigLoaded && canPatchConsoleOperatorConfig && !developmentMode ? (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes regression introduced in #14403. We only want to display the button when not in dev mode.

@@ -257,15 +279,16 @@ const ConsolePluginsTable: React.FC<ConsolePluginsTableProps> = ({ obj, rows, lo
({ name, version, description, status, enabled, errorMessage, hasCSPViolations }) => (
<Tr key={name}>
<Td dataLabel={columns[0].id}>
<ResourceLink groupVersionKind={consolePluginGVK} name={name} hideIcon />
{!developmentMode ? (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes regression introduced in #14403. We only want to display the link when not in dev mode.

Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few tweaks. Let me know your thoughts.

"Status": "Status",
"The state of the plugin.": "The state of the plugin.",
"Enabled": "Enabled",
"A boolean to determine whether or not the plugin renders in console.": "A boolean to determine whether or not the plugin renders in console.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about shortening it? I think the "whether or not" is implied.

Suggested change
"A boolean to determine whether or not the plugin renders in console.": "A boolean to determine whether or not the plugin renders in console.",
"A boolean to determine if the plugin renders in console.": "A boolean to determine if the plugin renders in console.",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @opayne1. I rewrote this while making some additions and just noticed your comment. The text now reads, Whether or not the plugin renders in console.. WDYT?

"Enabled": "Enabled",
"A boolean to determine whether or not the plugin renders in console.": "A boolean to determine whether or not the plugin renders in console.",
"CSP Violations": "CSP Violations",
"Plugin might have violated the Console Content Security Policy.": "Plugin might have violated the Console Content Security Policy.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one be similar to the one on line 235? or can we make it a complete sentence/

Suggested change
"Plugin might have violated the Console Content Security Policy.": "Plugin might have violated the Console Content Security Policy.",
"This plugin might have violated the Console Content Security Policy.": "This plugin might have violated the Console Content Security Policy.",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @opayne1. I rewrote this while making some additions and just noticed your comment. The text now reads, Whether or not the plugin might have violated the Console Content Security Policy.. WDYT?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?
  • add Version and Description below Display Name since they're included in the list view? | @jhadvig, WDYT?
Screen.Recording.2024-11-12.at.3.52.54.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?
  • add Version and Description below Display Name since they're included in the list view? | @jhadvig, WDYT?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.04.05.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.04.05.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.08.36.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.08.36.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first. Note #14374 includes a bug that needs to be addressed where not Loaded plugins do not appear in the Console plugins list.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.08.36.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member

jhadvig commented Nov 14, 2024

QE Approver:
/assign @yapei
Docs Approver:
/assign @opayne1
PX Approver:
/assign @reestr

Also worth to notice that this PR is cherry-picking CONSOLE-4264: Notify users of Console plugin related Content Security Policy violations and also contributing a fix for issue found by @yapei.

@opayne1 please review only commits contributed by @rhamilto, since @vojtechszocs was already reviewed by you.
@yapei please test only functionality related to the ConsolePlugin details page.
Thank you 🥇

@jhadvig jhadvig changed the title [WIP] CONSOLE-4269: add custom ConsolePlugin resource details page CONSOLE-4269: add custom ConsolePlugin resource details page Nov 14, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2024
@rhamilto
Copy link
Member Author

/test e2e-gcp-console

@reestr
Copy link

reestr commented Nov 15, 2024

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 15, 2024
@yanpzhan
Copy link
Contributor

Checked on cluster launched against the pr, tested consoleplugin 'Details' page and 'Plugin manifest' tab, features work as expected.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 15, 2024

@rhamilto: This pull request references CONSOLE-4269 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Includes changes from #14374, which should merge first. Note #14374 includes a bug that needs to be addressed where not Loaded plugins do not appear in the Console plugins list.

In collaboration with @vojtechszocs 🥇

TODOs:

  • improve Description, Version, Status, Enabled, and CSP Violations popover text | @opayne1, can you help here?

Demos

Plugin is Loaded

Screen.Recording.2024-11-13.at.4.03.13.PM.mov

Plugin is not Loaded (information from pluginStore is not available)

Screen.Recording.2024-11-13.at.4.08.36.PM.mov

Development setup

  1. Build, start, and run the console-demo-plugin locally.
  2. Apply the oc-manifest.yaml to the cluster.
  3. Visit http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 15, 2024
@jhadvig
Copy link
Member

jhadvig commented Nov 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2024
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

Hey, @rhamilto. This is great. I'm happy to see we have a nice details page.

Out of scope for this PR and story, but I had a few thoughts for future improvements:

  1. It would be good to show the plugin's supported OCP versions and make it clear when a plugin is disabled since its version range doesn't match the current OCP version. (I believe the supported versions are in the manifest, but would be good to have this on the overview tab. See plugin manifest properties.)
  2. Should we add a top-level nav items for Console Plugins to the Administration nav section? It would make it more discoverable.
  3. Syntax highlighting for the manifest JSON would be nice. Maybe we can use Monaco.
  4. I think a table of the extensions used by the plugin would be nice to have in addition to the manifest JSON (but keep the manifest tab for the complete JSON).

@jhadvig @vojtechszocs FYI

@rhamilto
Copy link
Member Author

Hey, @rhamilto. This is great. I'm happy to see we have a nice details page.

Thanks for the feedback, @spadgett.

  1. It would be good to show the plugin's supported OCP versions and make it clear when a plugin is disabled since its version range doesn't match the current OCP version. (I believe the supported versions are in the manifest, but would be good to have this on the overview tab. See plugin manifest properties.)

Easy enough to add.

  1. Should we add a top-level nav items for Console Plugins to the Administration nav section? It would make it more discoverable.

Agreed.

  1. Syntax highlighting for the manifest JSON would be nice. Maybe we can use Monaco.

@vojtechszocs and I started down the path of using Monaco, but decided against it for the initial implementation because the read only mode of the existing YAML editor posed some usability questions that we didn't have time to contend with.

  1. I think a table of the extensions used by the plugin would be nice to have in addition to the manifest JSON (but keep the manifest tab for the complete JSON).

Easy enough to add.

@openshift-merge-bot openshift-merge-bot bot merged commit 3f37ea0 into openshift:master Nov 15, 2024
6 of 7 checks passed
@rhamilto rhamilto deleted the CONSOLE-4269 branch November 15, 2024 23:45
@rhamilto
Copy link
Member Author

rhamilto commented Nov 19, 2024

  1. It would be good to show the plugin's supported OCP versions and make it clear when a plugin is disabled since its version range doesn't match the current OCP version. (I believe the supported versions are in the manifest, but would be good to have this on the overview tab. See plugin manifest properties.)

@spadgett, maybe something like this (note all the details in the video are not accurate such as Enabled)?

Screen.Recording.2024-11-19.at.9.08.21.AM.mov

@rhamilto
Copy link
Member Author

rhamilto commented Nov 19, 2024

3. Syntax highlighting for the manifest JSON would be nice. Maybe we can use Monaco.

@spadgett, we must've done something wonky with our initial attempt as this appears to be working correctly now.

I do wonder, is it weird to have two YAML editors?

Screen.Recording.2024-11-19.at.2.52.36.PM.mov

@rhamilto
Copy link
Member Author

rhamilto commented Nov 19, 2024

4. I think a table of the extensions used by the plugin would be nice to have in addition to the manifest JSON (but keep the manifest tab for the complete JSON).

Hmm. Given the variance amongst the extension properties, this one is a bit trickier to tabularize. 🤔

@spadgett
Copy link
Member

  1. It would be good to show the plugin's supported OCP versions and make it clear when a plugin is disabled since its version range doesn't match the current OCP version. (I believe the supported versions are in the manifest, but would be good to have this on the overview tab. See plugin manifest properties.)

@spadgett, maybe something like this (note all the details in the video are not accurate such as Enabled)?

Screen.Recording.2024-11-19.at.9.08.21.AM.mov

@rhamilto Yeah, that looks good. We should probably show the current console version in the warning popover and add something to the plugin list table if we don't already have it. We can make it a separate story.

@spadgett
Copy link
Member

  1. I think a table of the extensions used by the plugin would be nice to have in addition to the manifest JSON (but keep the manifest tab for the complete JSON).

Hmm. Given the variance amongst the extension properties, this one is a bit trickier to tabularize. 🤔

Yeah, I was hesitant about that, too. But even just the list of extension IDs would be helpful. We could show the resource kind for any extension that targets a specific resource and leave the column blank for other extension points. Or maybe not a table, but some other presentation.

@spadgett
Copy link
Member

  1. Syntax highlighting for the manifest JSON would be nice. Maybe we can use Monaco.

@spadgett, we must've done something wonky with our initial attempt as this appears to be working correctly now.

I do wonder, is it weird to have two YAML editors?

Yeah, I'm undecided. Maybe we can style it differently or simplify the editor to make it more clear that it's read-only?

All of these suggestions can be follow-up PRs, particularly since this has merged. I'd say the compatible versions tweak is the most important to help admins troubleshoot plugins that aren't enabled.

@rhamilto
Copy link
Member Author

2. Should we add a top-level nav items for Console Plugins to the Administration nav section? It would make it more discoverable.

Made this a bug so we can backport: #14521 @spadgett, mind reviewing?

logonoff added a commit to logonoff/openshift-console that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants