Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Allow LiteralTestStep.timeout to be overridden #4449

Open
afcollins opened this issue Dec 16, 2024 · 0 comments
Open

RFE: Allow LiteralTestStep.timeout to be overridden #4449

afcollins opened this issue Dec 16, 2024 · 0 comments

Comments

@afcollins
Copy link

Background

We have many openshift/release jobs re-using common steps, like the "gather" steps.

The current configuration allows step timeouts as a statically-configured code change (for example), which means we must set to accommodate the slowest possible scenario.

However, smaller jobs may want to set a lower timeout so they can budget more time for other steps. We have seen that if a cluster-under-test is already broken, then the m-g step will not allow any following steps to complete before the job is terminated by the job-level timeout.

The enhancement:

Allow some means for a LiteralTestStep.Timeout to be overridden by an "end-user" test config (example).

Alternatives

It is possible there may be some way for us to achieve this configuration we may have missed. Please share with us if that's possible.

One way that comes to mind is cloning the step-registry ref so we can set different timeouts, but that seems like a fragile kind of forking approach that will create more maintenance burden on the test developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant