-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix cancel in progress to act on same pr/branch #1826
Conversation
Deploying pipelines-as-code with Cloudflare Pages
|
I have a new laptop and the setup create pr against origin instead of my fork, should be fixed for next pr |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
==========================================
+ Coverage 65.28% 65.34% +0.06%
==========================================
Files 177 177
Lines 13674 13692 +18
==========================================
+ Hits 8927 8947 +20
Misses 4143 4143
+ Partials 604 602 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
copyng a comment i made offline on a slack discussion:
|
a150f0a
to
6e8c278
Compare
fixed the e2e-tests and made it to test over over multiple pull request, rephrased documentation to make it clear how the cancellation selection works. |
6e8c278
to
86c8bed
Compare
We need to ensure that we only cancel the pipeline run that is running on the same branch as the current PR or push event. This ensures that we don't cancel the wrong pipeline run. On PullRequest events, we only cancel the pipeline run that is running on the same Pull Request number. On Push events, we only cancel the pipeline run that is running on the same SourceBranch (which is the same as HeadBranch on push) This avoids the issue when you have multiple pull request running on a repo and we don't cancel the wrong ones that are running for a different PR. Signed-off-by: Chmouel Boudjnah <[email protected]>
86c8bed
to
bb7375f
Compare
Changes
We need to ensure that we only cancel the pipeline run that is running
on the same branch as the current PR or push event. This ensures that we
don't cancel the wrong pipeline run.
On PullRequest events, we only cancel the pipeline run that is running
on the same Pull Request number.
On Push events, we only cancel the pipeline run that is running on the
same SourceBranch (which is the same as HeadBranch on push)
This avoids the issue when you have multiple pull request running on a
repo and we don't cancel the wrong ones that are running for a different
PR.
Tried to do e2e tests but it ended too flaky.
Submitter Checklist
X
X
X
X
X
X