Add support for GitOps comments on Push commits #1638
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
==========================================
- Coverage 65.31% 65.30% -0.02%
==========================================
Files 177 177
Lines 13647 13646 -1
==========================================
- Hits 8914 8911 -3
- Misses 4134 4136 +2
Partials 599 599 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
chmouel
force-pushed
the
SRVKP-4179-gitops-comments-on-test
branch
5 times, most recently
from
db66b1c
to
6c8e044
Compare
chmouel
force-pushed
the
SRVKP-4179-gitops-comments-on-test
branch
2 times, most recently
from
b760cb0
to
b44b6d3
Compare
| runevent.EventType = "push" | ||
| runevent.TriggerTarget = "push" | ||
| runevent.TriggerTarget = triggertype.Push | ||
| opscomments.SetEventTypeAndTargetPR(runevent, event.GetComment().GetBody()) |
There was a problem hiding this comment.
I tried to verify
/hello-world works fine on latest pushed commits
but when i try to do on different branches
/hello-world branch:newbranch
Its not working as expected where as /test branch:newbranch works fine
There was a problem hiding this comment.
it's fine i guess to say that's not working properly since my feeling is that it's a bit of a edge case
1 task
chmouel
force-pushed
the
SRVKP-4179-gitops-comments-on-test
branch
from
b44b6d3
to
266c125
Compare
Add supports for GitOps comments on Push commits when using the Git Provider. Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
SRVKP-4179-gitops-comments-on-test
branch
from
266c125
to
62df1d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add supports for GitOps comments on Push commits when using the Git Provider.
Moved the RunPush function to use scm.PushFiles (which use the git binary instead of api) to push files like we do on gitea, since pushing to main via go-github was too painful..
Jira: https://issues.redhat.com/browse/SRVKP-4179
Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).