Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create github token from tkn-pac #680

Open
chmouel opened this issue May 13, 2022 · 0 comments · May be fixed by #1736
Open

Create github token from tkn-pac #680

chmouel opened this issue May 13, 2022 · 0 comments · May be fixed by #1736
Assignees
@zakisk
Labels
cli feature New feature or request

Comments

@chmouel
Copy link
Member

chmouel commented May 13, 2022

We currently send folks to a web browser to create token,

We can definitively do it the same way gh auth does it :

image

it redirect to this page :

https://github.com/login/device

which then it use its internal library authflow :

https://github.com/cli/cli/blob/trunk/internal/authflow/flow.go

to validate it and get the token

we would probably need to create our own here:

https://github.com/cli/cli/blob/trunk/internal/authflow/flow.go#L21-L24

and we can reuse the same logic for Github Enteprise...
@chmouel chmouel added feature New feature or request cli labels May 13, 2022
@chmouel chmouel added this to the 0.9.0 milestone May 13, 2022
@chmouel chmouel modified the milestones: 0.9.0, 0.11.0 Jun 29, 2022
@chmouel chmouel self-assigned this Jun 29, 2022
@sm43 sm43 modified the milestones: 0.11.0, 0.12.0 Jul 19, 2022
@sm43 sm43 modified the milestones: 0.12.0, 0.13.0 Nov 14, 2022
@zakisk zakisk assigned zakisk and unassigned chmouel Jun 10, 2024
@zakisk zakisk mentioned this issue Jun 18, 2024
Closed
7 tasks
zakisk pushed a commit to zakisk/pipelines-as-code that referenced this issue Jul 9, 2024
Add new \auth\ subcommand in \tkn-pac\
c7e93d0 
Adds new auth subcommand in tkn-pac CLI
that authenticate users with git providers
and stores git provider token for further use.

fix openshift-pipelines#680
https://issues.redhat.com/browse/SRVKP-5548

Signed-off-by: Zaki Shaikh <[email protected]>
zakisk pushed a commit to zakisk/pipelines-as-code that referenced this issue Jul 10, 2024
Add new subcommand auth in tkn-pac CLI
422383a 
Adds new subcommand to authenticate user with git providers
and stores those token locally for further use of tkn-pac

fix openshift-pipelines#680
https://issues.redhat.com/browse/SRVKP-5548

Signed-off-by: Zaki Shaikh <[email protected]>
@zakisk zakisk linked a pull request Jul 10, 2024 that will close this issue
Open
zakisk pushed a commit to zakisk/pipelines-as-code that referenced this issue Aug 20, 2024
Add new subcommand auth in tkn-pac CLI
d44d25b 
Adds new subcommand to authenticate user with git providers
and stores those token locally for further use of tkn-pac

fix openshift-pipelines#680
https://issues.redhat.com/browse/SRVKP-5548

Signed-off-by: Zaki Shaikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakisk zakisk

Labels
cli feature New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new subcommand auth in tkn-pac CLI zakisk/pipelines-as-code
3 participants
@chmouel @zakisk @sm43