-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: support commas in PipelineRun annotations
This commit introduces support for using commas within annotations by allowing users to escape them with the HTML entity `,`. This ensures compatibility with annotations that rely on comma-separated values while also permitting the inclusion of literal commas in file paths or branch names. This enhancement maintains backward compatibility while enabling more precise and flexible use of annotations. **Jira**: https://issues.redhat.com/browse/SRVKP-6790 **Signed-off-by**: Chmouel Boudjnah <[email protected]> Signed-off-by: Chmouel Boudjnah <[email protected]>
- Loading branch information
Showing
7 changed files
with
198 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
apiVersion: tekton.dev/v1beta1 | ||
kind: PipelineRun | ||
metadata: | ||
name: "\\ .PipelineName //" | ||
annotations: | ||
pipelinesascode.tekton.dev/target-namespace: "\\ .TargetNamespace //" | ||
pipelinesascode.tekton.dev/on-target-branch: "[ branch,with,comma ]" | ||
pipelinesascode.tekton.dev/on-event: "[\\ .TargetEvent //]" | ||
spec: | ||
pipelineSpec: | ||
tasks: | ||
- name: task | ||
taskSpec: | ||
steps: | ||
- name: success | ||
image: registry.access.redhat.com/ubi9/ubi-micro | ||
script: | | ||
echo "I am a such a good booooy" | ||
exit 0 |