Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Benchmark Rest Apis #202

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rishabh6788
Copy link

@rishabh6788 rishabh6788 commented Sep 3, 2024

Description

This PR introduces following rest apis to help opensource opensearch-project contributors submit ad-hoc benchmark runs on our jenkins infra. They do not need to log-in to the jenkins to submit the job as long as they are authorized using github teams.

  • submitBenchmarkRun: Rest api to submit ad-hoc benchmark using artifact tarball. Will re-use jenkin's benchmark-pull-request job to run benchmark.
  • submitBenchmarkEndpointRun: Rest api to submit ad-hoc benchmark against user's cluster endpoint. Will use benchmark-test-endpoint to run benchmark.

See detailed design in opensearch-project/opensearch-build#4231

Issues Resolved

opensearch-project/opensearch-build#4788

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishabh Singh <[email protected]>
@rishabh6788 rishabh6788 marked this pull request as ready for review September 5, 2024 04:46
@rishabh6788 rishabh6788 force-pushed the main branch 6 times, most recently from e65e0a8 to e1ba7ab Compare September 5, 2024 05:02
@rishabh6788
Copy link
Author

@peterzhuamazon @gaiksaya Please provide review comments and feedback whenever you can.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good on the 1st pass.

In offline conversation, I raise the question of having a limit set in API Gateway so that to prevent potential spamming on the API calls.

Thanks.

@rishabh6788
Copy link
Author

Generally good on the 1st pass.

In offline conversation, I raise the question of having a limit set in API Gateway so that to prevent potential spamming on the API calls.

Thanks.

Added throttling rule to api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📦 Backlog
Development

Successfully merging this pull request may close these issues.

2 participants