-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Benchmark Rest Apis #202
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
e65e0a8
to
e1ba7ab
Compare
Signed-off-by: Rishabh Singh <[email protected]>
@peterzhuamazon @gaiksaya Please provide review comments and feedback whenever you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good on the 1st pass.
In offline conversation, I raise the question of having a limit set in API Gateway so that to prevent potential spamming on the API calls.
Thanks.
Signed-off-by: Rishabh Singh <[email protected]>
Added throttling rule to api. |
Description
This PR introduces following rest apis to help opensource opensearch-project contributors submit ad-hoc benchmark runs on our jenkins infra. They do not need to log-in to the jenkins to submit the job as long as they are authorized using github teams.
submitBenchmarkRun
: Rest api to submit ad-hoc benchmark using artifact tarball. Will re-use jenkin's benchmark-pull-request job to run benchmark.submitBenchmarkEndpointRun
: Rest api to submit ad-hoc benchmark against user's cluster endpoint. Will use benchmark-test-endpoint to run benchmark.See detailed design in opensearch-project/opensearch-build#4231
Issues Resolved
opensearch-project/opensearch-build#4788
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.