-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete API spec implementation for flow_framework #565
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b789b85
Add some 4xx error test
4a4503a
1. Adding API spec for GET /workflow/_steps
b957fdb
1. Adding API spec for GET /workflow/_status
0ea367e
1. Adding API spec for POST /workflow/_deprovision
2132794
1. Adding API spec for POST /workflow/_provision
06e14c0
1. Adding API spec for POST /workflow/_search
312b471
1. Adding API spec for POST/GET /workflow/state/_search
14fe053
add change log
62fcc2e
Update tests/default/flow_framework/workflow.yaml
junweid62 8543168
change searchStateResponse spec.
7c76787
update workflow.yaml add new test file seperate test senario
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -192,4 +192,5 @@ vectory | |
whoamiprotected | ||
wordnet | ||
Yrtsd | ||
reprovision | ||
reprovision | ||
deprovision |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure "duplicate key" is self-descriptive here. Is this a duplicate param, or a duplicate field in the body JSON?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/opensearch-project/flow-framework/blob/dc20feb9d25b7c60bd76c8f5cc66a5a1eed860e2/src/main/java/org/opensearch/flowframework/rest/RestProvisionWorkflowAction.java#L125C2-L128C22
Because we can pass it as a query parameter or as a string value of a request body field
The error message is this. I naming
DuplicateKeyError
by the error message, should i change it ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me, should match the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now as @dblock says it's ok to match the code. The error message should probably be "duplicate param" but not a big deal to leave it as is. If you get the message you'll know what you did wrong. Whoever wrote that code should have thought better. ;)